Improve error messages for failed 3D meshing

Added failed_faces and failed_polys files for failed faces and polys.

Author: rquey

VERSIONS

@@ -1,6 +1,7 @@
-New in 4.8.2-6 (21 Mar 2024):
+New in 4.8.2-7 (22 Mar 2024):
 - module -T: added -transform "cut(cube)", improved -transform "cut(cubei)",
   made minor improvements.
+- module -M: made minor improvements.
 
 New in 4.8.1 (02 Feb 2024):
 - general: fixed compatibility with Gmsh (version 4.12.2).

doc/conf.py

@@ -11,8 +11,8 @@
 import sphinx_rtd_theme
 
 project = u'Neper'
-version = u'4.8.2-6'
-release = u'4.8.2-6'
+version = u'4.8.2-7'
+release = u'4.8.2-7'
 author = u'Romain Quey'
 copyright = u'Romain Quey'
 language = 'en'

src/CMakeLists.txt

@@ -7,7 +7,7 @@ if(POLICY CMP0077)
   cmake_policy(SET CMP0077 NEW)
 endif()
 
-set(NEPER_VERSION \"4.8.2-6\")
+set(NEPER_VERSION \"4.8.2-7\")
 project(neper)
 
 if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8.1)

src/neper_m/nem/nem_mesh_gmsh/nem_mesh_gmsh1.c

@@ -14,7 +14,7 @@ nem_mesh_3d_gmsh (struct TESS Tess, int poly, struct NODES Nodes,
   FILE *file, *file2;
   char *Args = NULL;
   struct timeval beg_time, end_time;
-  int nb, optinb, status;
+  int nb, optinb, status, status2;
   struct MESH M2;
   int **Elsets = NULL;
   int ElsetQty;
@@ -119,7 +119,16 @@ nem_mesh_3d_gmsh (struct TESS Tess, int poly, struct NODES Nodes,
     {
       status = 0;
       file = ut_file_open (filename_msh, "R");
-      neut_mesh_fscanf_msh (file, pN, NULL, NULL, NULL, pM, NULL, NULL);
+      status2 = neut_mesh_fscanf_msh (file, pN, NULL, NULL, NULL, pM, NULL, NULL);
+      if (status2)
+      {
+        FILE *fp = ut_file_open ("failed_polys", "w");
+        fprintf (fp, "%d\n", poly);
+        fflush (fp);
+        ut_file_close (fp, "failed_polys", "w");
+        ut_print_message (2, 0, "Meshing failed\n");
+      }
+
       ut_file_close (file, filename_msh, "R");
     }
 

src/neper_m/nem_meshing/nem_meshing_3d/nem_meshing_3d2.c

@@ -47,8 +47,13 @@ nem_meshing_3d_poly (struct IN_M In, double cl, double mesh3dclreps,
 #pragma omp atomic
     (*pMultim).algohit[(*pMultim).Oalgo[poly]]++;
   else
+  {
+    FILE *fp = ut_file_open ("failed_polys", "w");
+    fprintf (fp, "%d\n", poly);
+    ut_file_close (fp, "failed_polys", "w");
     ut_print_message (2, 3, "Meshing of poly %d (%d) failed\n", poly,
                       neut_tess_cell_id (Tess, poly));
+  }
 
   neut_nodes_free (&N2);
   neut_mesh_free (&M2);

src/neper_m/nem_meshing_para/nem_meshing_para_faceproj/nem_meshing_para_faceproj1.c

@@ -12,6 +12,7 @@ nem_meshing_para_faceproj (struct TESS Tess, struct NODES RNodes,
   char *message = ut_alloc_1d_char (8);
   int *failed = ut_alloc_1d_int (Tess.FaceQty + 1);
   int failed_sum;
+  FILE *file = NULL;
 
   (*pMeshPara).face_eq = ut_alloc_2d (Tess.FaceQty + 1, 4);
 
@@ -33,7 +34,8 @@ nem_meshing_para_faceproj (struct TESS Tess, struct NODES RNodes,
     status =
       nem_meshing_para_faceproj_eq (Tess, RNodes, RMesh, i,
                                     (*pMeshPara).face_eq[i]);
-    if (status == -1)
+
+    if (status != 0)
     {
       if (!strcmp ((*pMeshPara).face_op[i], "meshproj"))
         ut_string_string ("copy", (*pMeshPara).face_op + i);
@@ -55,6 +57,19 @@ nem_meshing_para_faceproj (struct TESS Tess, struct NODES RNodes,
       if (failed[i])
         printf (" %d", i);
     printf (".\n");
+
+    file = ut_file_open ("failed_faces", "w");
+    for (i = 1; i <= Tess.FaceQty; i++)
+      if (failed[i])
+        fprintf (file, "%d\n", i);
+    ut_file_close (file, "failed_faces", "w");
+
+    file = ut_file_open ("failed_polys", "w");
+    for (i = 1; i <= Tess.FaceQty; i++)
+      if (failed[i])
+        fprintf (file, "%d %d\n", Tess.FacePoly[i][0], Tess.FacePoly[i][1]);
+    ut_file_close (file, "failed_polys", "w");
+
     abort ();
   }
 

src/neut/neut_mesh/neut_mesh_fscanf/neut_mesh_fscanf_msh/neut_mesh_fscanf_msh.h

@@ -9,7 +9,7 @@ extern "C"
 
 #ifndef NEUT_MESH_FSCANF_GMSH
 
-  extern void neut_mesh_fscanf_msh (FILE * file, struct NODES *pNodes,
+  extern int neut_mesh_fscanf_msh (FILE * file, struct NODES *pNodes,
 				    struct MESH *pMesh0D,
 				    struct MESH *pMesh1D,
 				    struct MESH *pMesh2D,

src/neut/neut_mesh/neut_mesh_fscanf/neut_mesh_fscanf_msh/neut_mesh_fscanf_msh1.c

@@ -4,12 +4,13 @@
 
 #include"neut_mesh_fscanf_msh_.h"
 
-void
+int
 neut_mesh_fscanf_msh (FILE * file, struct NODES *pNodes, struct MESH *pMesh0D,
                       struct MESH *pMesh1D, struct MESH *pMesh2D,
                       struct MESH *pMesh3D, struct MESH *pMeshCo,
                       int *ptopology)
 {
+  int status;
   int *node_nbs = NULL;
   char *mode = NULL, *domain = NULL;
   struct MESH *pMesh = NULL;
@@ -33,8 +34,12 @@ neut_mesh_fscanf_msh (FILE * file, struct NODES *pNodes, struct MESH *pMesh0D,
       neut_mesh_fscanf_msh_nodes (file, mode, pNodes, &node_nbs);
 
     else if (ut_file_nextstring_test (file, "$Elements"))
-      neut_mesh_fscanf_msh_elts (file, mode, domain, node_nbs, pMesh0D, pMesh1D, pMesh2D,
+    {
+      status = neut_mesh_fscanf_msh_elts (file, mode, domain, node_nbs, pMesh0D, pMesh1D, pMesh2D,
                                  pMesh3D, pMeshCo, &pMesh);
+      if (status)
+        return -1;
+    }
 
     else if (ut_file_nextstring_test (file, "$Periodicity"))
       neut_mesh_fscanf_msh_periodicity (file, pNodes);
@@ -69,7 +74,7 @@ neut_mesh_fscanf_msh (FILE * file, struct NODES *pNodes, struct MESH *pMesh0D,
 
   ut_free_1d_char (&mode);
 
-  return;
+  return 0;
 }
 
 void

src/neut/neut_mesh/neut_mesh_fscanf/neut_mesh_fscanf_msh/neut_mesh_fscanf_msh2.c

@@ -119,13 +119,13 @@ neut_mesh_fscanf_msh_nodes (FILE * file, char *mode,
   return;
 }
 
-void
+int
 neut_mesh_fscanf_msh_elts (FILE * file, char *mode, char *domain, int *node_nbs,
                            struct MESH *pMesh0D, struct MESH *pMesh1D,
                            struct MESH *pMesh2D, struct MESH *pMesh3D,
                            struct MESH *pMeshCo, struct MESH **ppMesh)
 {
-  int leftelts, dim;
+  int leftelts, dim, status;
   struct MESH Trash;
 
   neut_mesh_set_zero (&Trash);
@@ -140,29 +140,34 @@ neut_mesh_fscanf_msh_elts (FILE * file, char *mode, char *domain, int *node_nbs,
   if (!strcmp (mode, "binary"))
     if (fscanf (file, "%c", &c) != 1)
       abort ();
-  leftelts -=
-    neut_mesh_fscanf_msh_elts_dim (file, mode, pMesh0D ? pMesh0D : &Trash, node_nbs, 0,
-                   leftelts);
+  status = neut_mesh_fscanf_msh_elts_dim (file, mode, pMesh0D ? pMesh0D : &Trash, node_nbs, 0,
+                 &leftelts);
+  if (status != 0)
+    return status;
   if (pMesh0D && (*pMesh0D).EltQty > 0)
     dim = 0;
-  leftelts -=
-    neut_mesh_fscanf_msh_elts_dim (file, mode, pMesh1D ? pMesh1D : &Trash, node_nbs, 1,
-                   leftelts);
+  status = neut_mesh_fscanf_msh_elts_dim (file, mode, pMesh1D ? pMesh1D : &Trash, node_nbs, 1,
+                 &leftelts);
+  if (status != 0)
+    return status;
   if (pMesh1D && (*pMesh1D).EltQty > 0)
     dim = 1;
-  leftelts -=
-    neut_mesh_fscanf_msh_elts_dim (file, mode, pMesh2D ? pMesh2D : &Trash, node_nbs, 2,
-                   leftelts);
+  status = neut_mesh_fscanf_msh_elts_dim (file, mode, pMesh2D ? pMesh2D : &Trash, node_nbs, 2,
+                 &leftelts);
+  if (status != 0)
+    return status;
   if (pMesh2D && (*pMesh2D).EltQty > 0)
     dim = 2;
-  leftelts -=
-    neut_mesh_fscanf_msh_elts_dim (file, mode, pMesh3D ? pMesh3D : &Trash, node_nbs, 3,
-                   leftelts);
+  status = neut_mesh_fscanf_msh_elts_dim (file, mode, pMesh3D ? pMesh3D : &Trash, node_nbs, 3,
+                   &leftelts);
+  if (status != 0)
+    return status;
   if (pMesh3D && (*pMesh3D).EltQty > 0)
     dim = 3;
-  leftelts -=
-    neut_mesh_fscanf_msh_elts_dim (file, mode, pMeshCo ? pMeshCo : &Trash, node_nbs, dim,
-                   leftelts);
+  status = neut_mesh_fscanf_msh_elts_dim (file, mode, pMeshCo ? pMeshCo : &Trash, node_nbs, dim,
+                 &leftelts);
+  if (status != 0)
+    return status;
 
   ut_free_1d_int (&node_nbs);
 
@@ -197,7 +202,7 @@ neut_mesh_fscanf_msh_elts (FILE * file, char *mode, char *domain, int *node_nbs,
 
   neut_mesh_free (&Trash);
 
-  return;
+  return 0;
 }
 
 void

src/neut/neut_mesh/neut_mesh_fscanf/neut_mesh_fscanf_msh/neut_mesh_fscanf_msh3.c

@@ -69,22 +69,22 @@ neut_mesh_fscanf_msh_nodes_foot (FILE * file)
 
 int
 neut_mesh_fscanf_msh_elts_dim (FILE * file, char *mode, struct MESH *pMesh, int *node_nbs,
-               int Dimension, int MaxEltQty)
+               int Dimension, int *pMaxEltQty)
 {
   int *elt_nbs = NULL;
   int *elset_nbs = NULL;
 
   neut_mesh_reset (pMesh);
 
   if (Dimension < 0 || Dimension > 3)
-    ut_print_message (2, 0, "Wrong mesh dimension: %d!\n", Dimension);
+    return -1;
 
-  if (MaxEltQty != 0)
+  if (*pMaxEltQty != 0)
   {
     (*pMesh).Dimension = Dimension;
 
     neut_mesh_fscanf_msh_elts_dim_prop (file, mode, pMesh, &elt_nbs,
-                                        MaxEltQty);
+                                        *pMaxEltQty);
 
     neut_mesh_init_elsets_2 (pMesh, elt_nbs, &elset_nbs);
 
@@ -102,5 +102,7 @@ neut_mesh_fscanf_msh_elts_dim (FILE * file, char *mode, struct MESH *pMesh, int
   ut_free_1d_int (&elt_nbs);
   ut_free_1d_int (&elset_nbs);
 
-  return (*pMesh).EltQty;
+  (*pMaxEltQty) -= (*pMesh).EltQty;
+
+  return 0;
 }