Skip to content

Commit ad20c87

Browse files
author
Naor Livne
committed
on 2nd thought best to keep the requests format and just make a note of it
1 parent b50835e commit ad20c87

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

NebulaPythonSDK/sdk.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,49 +25,49 @@ def create_app(self, app, config):
2525
payload = json.dumps(config)
2626
headers = self.headers
2727
response = requests.request("POST", url, data=payload, headers=headers, timeout=self.request_timeout)
28-
return json.dumps(response.json())
28+
return response
2929

3030
# delete an existing nebula app, no confirmation required in SDK so be careful
3131
def delete_app(self, app):
3232
url = self.host + "/api/apps/" + app
3333
headers = self.headers
3434
response = requests.request("DELETE", url, headers=headers, timeout=self.request_timeout)
35-
return json.dumps(response.json())
35+
return response
3636

3737
# list all of the apps managed by nebula
3838
def list_apps(self):
3939
url = self.host + "/api/apps"
4040
headers = self.headers
4141
response = requests.request("GET", url, headers=headers, timeout=self.request_timeout)
42-
return json.dumps(response.json()["apps"])
42+
return response
4343

4444
# list the config of a nebula app, only requires the app name
4545
def list_app_info(self, app):
4646
url = self.host + "/api/apps/" + app
4747
headers = self.headers
4848
response = requests.request("GET", url, headers=headers, timeout=self.request_timeout)
49-
return json.dumps(response.json())
49+
return response
5050

5151
# stop a nebula app, only requires the app name
5252
def stop_app(self, app):
5353
url = self.host + "/api/apps/" + app + "/stop"
5454
headers = self.headers
5555
response = requests.request("POST", url, headers=headers, timeout=self.request_timeout)
56-
return json.dumps(response.json())
56+
return response
5757

5858
# start a nebula app, only requires the app name
5959
def start_app(self, app):
6060
url = self.host + "/api/apps/" + app + "/start"
6161
headers = self.headers
6262
response = requests.request("POST", url, headers=headers, timeout=self.request_timeout)
63-
return json.dumps(response.json())
63+
return response
6464

6565
# restart a nebula app, only requires the app name
6666
def restart_app(self, app):
6767
url = self.host + "/api/apps/" + app + "/restart"
6868
headers = self.headers
6969
response = requests.request("POST", url, headers=headers, timeout=self.request_timeout)
70-
return json.dumps(response.json())
70+
return response
7171

7272
# update a nebula app, requires the app name and a dict of the config values you want to change, any combination of
7373
# config values is accepted as it keeps the rest unchanged
@@ -76,18 +76,18 @@ def update_app(self, app, config):
7676
payload = json.dumps(config)
7777
headers = self.headers
7878
response = requests.request("PUT", url, data=payload, headers=headers, timeout=self.request_timeout)
79-
return json.dumps(response.json())
79+
return response
8080

8181
# rolling restart an app, only requires the app name
8282
def roll_app(self, app):
8383
url = self.host + "/api/apps/" + app + "/roll"
8484
headers = self.headers
8585
response = requests.request("POST", url, headers=headers, timeout=self.request_timeout)
86-
return json.dumps(response.json())
86+
return response
8787

8888
# check that the contacted api is responding as expected
8989
def check_api(self):
9090
url = self.host + "/api/status"
9191
headers = self.headers
9292
response = requests.request("GET", url, headers=headers, timeout=self.request_timeout)
93-
return json.dumps(response.json())
93+
return response

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,5 @@ app_conf = {
5151
connection.create_app("app_name", app_conf)
5252

5353
```
54+
55+
Note that the response returned is a requests formatted response.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
__author__ = 'Naor Livne'
22
__author_email__ = 'naorlivne@gmail.com'
3-
__version__ = '1.5.0'
3+
__version__ = '1.5.1'
44

55
from setuptools import setup, find_packages
66

0 commit comments

Comments
 (0)