fix: new allowCssPropagation property (false by default)

Author: farfromrefug

src/collectionview/index-common.ts

@@ -113,6 +113,7 @@ export abstract class CollectionViewBase extends View implements CollectionViewD
     public static dataPopulatedEvent = 'dataPopulated';
     public static knownFunctions = ['itemTemplateSelector', 'itemIdGenerator', 'spanSize']; // See component-builder.ts isKnownFunction
 
+    public allowCssPropagation: boolean;
     public isBounceEnabled: boolean;
     public isScrollEnabled: boolean;
     public reverseLayout: boolean;
@@ -736,6 +737,13 @@ export const autoReloadItemOnLayoutProperty = new Property<CollectionViewBase, b
 });
 autoReloadItemOnLayoutProperty.register(CollectionViewBase);
 
+export const allowCssPropagationProperty = new Property<CollectionViewBase, boolean>({
+    name: 'allowCssPropagation',
+    defaultValue: false,
+    valueConverter: booleanConverter
+});
+allowCssPropagationProperty.register(CollectionViewBase);
+
 export const itemOverlapProperty = new Property<CollectionViewBase, Function>({
     name: 'itemOverlap',
     defaultValue: undefined,

src/collectionview/index.android.ts

@@ -1248,11 +1248,15 @@ export class CollectionView extends CollectionViewBase {
             parentView.id = 'collectionViewHolder';
             view = parentView;
         }
-        //@ts-ignore
-        view.parent = this;
-        view._setupAsRootView(this._context);
-        view._isAddedToNativeVisualTree = true;
-        view.callLoaded();
+
+        if (this.allowCssPropagation) {
+            this._addView(view);
+        } else {
+            view.parent = this;
+            view._setupAsRootView(this._context);
+            view._isAddedToNativeVisualTree = true;
+            view.callLoaded();
+        }
         if (!CollectionViewCellHolder) {
             CollectionViewCellHolder = com.nativescript.collectionview.CollectionViewCellHolder as any;
         }

src/collectionview/index.ios.ts

@@ -84,7 +84,6 @@ export enum SnapPosition {
     END = 1 // = androidx.recyclerview.widget.LinearSmoothScroller.SNAP_TO_END
 }
 
-
 export class CollectionView extends CollectionViewBase {
     //TODO: remove as it needs to be added after TS 5.7 change https://github.com/microsoft/TypeScript/pull/59860
     [key: symbol]: (...args: any[]) => any | void;
@@ -837,7 +836,7 @@ export class CollectionView extends CollectionViewBase {
     scrollToOffset(value, animated) {
         const view = this.nativeViewProtected;
         if (view && this.isScrollEnabled) {
-            const { width, height } = view.bounds.size;
+            const { height, width } = view.bounds.size;
             let rect: CGRect;
             if (this.orientation === 'vertical') {
                 rect = CGRectMake(0, value, width, height);
@@ -924,7 +923,14 @@ export class CollectionView extends CollectionViewBase {
             }
 
             if (view && !view.parent) {
-                this._addView(view);
+                if (this.allowCssPropagation) {
+                    this._addView(view);
+                } else {
+                    view.parent = this;
+                    view._setupAsRootView(this._context);
+                    view._isAddedToNativeVisualTree = true;
+                    view.callLoaded();
+                }
                 const innerView = NSCellView.new() as NSCellView;
                 innerView.autoresizingMask = UIViewAutoresizing.FlexibleWidth | UIViewAutoresizing.FlexibleHeight;
                 innerView.view = new WeakRef(view);