POSIX compatibility

[Pesa]

This package is targeted at "POSIX compatible OS". However, looking at the code, I noticed several incompatibilities with POSIX. These are a couple of examples I saw so far, but I only took a quick look and there may be others:

ndn-iot-package-over-posix/adaptation/udp/udp-face.c

Lines 203 to 204 in 4b31168

	size = recvfrom(ptr->sock, ptr->buf, sizeof(ptr->buf), MSG_DONTWAIT,
	(struct sockaddr*)&client_addr, &addr_len);

MSG_DONTWAIT is not specified by POSIX.

ndn-iot-package-over-posix/adaptation/udp/udp-face.c

Line 208 in 4b31168

}else if(size == -1 && errno == EWOULDBLOCK){

POSIX.1-2001 allows either EAGAIN or EWOULDBLOCK to be returned for this case, and does not guarantee that these constants have the same value, so a portable application should check for both.

ndn-iot-package-over-posix/adaptation/udp/udp-face.c

Line 58 in 4b31168

if(ioctl(ptr->sock, FIONBIO, (char *)&iyes) == -1){

FIONBIO is non-standard. You should use fcntl(...O_NONBLOCK...) instead.

[zjkmxy]

Fixed. Thank you for your comments!

[Pesa]

Well... there are several more instances of these or similar problems still present in the codebase... how do you plan to address them? The 3 cases I reported above were just a few examples I noticed from a quick look.

[zjkmxy]

We are planning to review our design recently. I will figure it out then.

[Pesa]

Any updates?

[zjkmxy]

No. Till now we haven't figured out what else is not compatible to POSIX.

[yoursunny]

Is there a linter that automatically find non POSIX complaint function calls?