Skip to content

Commit a7ef28e

Browse files
authored
Merge pull request #46 from nWidart/feature/laravel-6.0
Updating dependencies to laravel 6.0.
2 parents e6a97cf + 205e0d4 commit a7ef28e

File tree

5 files changed

+21
-19
lines changed

5 files changed

+21
-19
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
language: php
22

33
php:
4-
- 7.1
54
- 7.2
5+
- 7.3
66

77
cache:
88
directories:

Tests/MenuItemTest.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Nwidart\Menus\Tests;
44

5+
use Illuminate\Support\Arr;
56
use Nwidart\Menus\Menu;
67
use Nwidart\Menus\MenuItem;
78

@@ -123,7 +124,7 @@ public function it_can_make_a_simple_route_menu_item()
123124
$children = $menuItem->getChilds()[0]->getChilds();
124125

125126
$this->assertCount(1, $children);
126-
$childMenuItem = array_first($children);
127+
$childMenuItem = Arr::first($children);
127128
$this->assertEquals('settings.account', $childMenuItem->route[0]);
128129
$this->assertEquals(['user_id' => 1], $childMenuItem->route[1]);
129130
}
@@ -138,7 +139,7 @@ public function it_can_make_a_route_menu_item()
138139
$children = $menuItem->getChilds()[0]->getChilds();
139140

140141
$this->assertCount(1, $children);
141-
$childMenuItem = array_first($children);
142+
$childMenuItem = Arr::first($children);
142143
$this->assertEquals('settings.account', $childMenuItem->route[0]);
143144
$this->assertEquals(['user_id' => 1], $childMenuItem->route[1]);
144145
$this->assertSame(1, $childMenuItem->order);
@@ -155,7 +156,7 @@ public function it_can_make_a_simple_url_menu_item()
155156
$children = $menuItem->getChilds()[0]->getChilds();
156157

157158
$this->assertCount(1, $children);
158-
$childMenuItem = array_first($children);
159+
$childMenuItem = Arr::first($children);
159160
$this->assertEquals('settings/account', $childMenuItem->url);
160161
$this->assertEquals('Account', $childMenuItem->title);
161162
}
@@ -170,7 +171,7 @@ public function it_can_make_a_url_menu_item()
170171
$children = $menuItem->getChilds()[0]->getChilds();
171172

172173
$this->assertCount(1, $children);
173-
$childMenuItem = array_first($children);
174+
$childMenuItem = Arr::first($children);
174175
$this->assertEquals('settings/account', $childMenuItem->url);
175176
$this->assertEquals('Account', $childMenuItem->title);
176177
$this->assertSame(1, $childMenuItem->order);
@@ -229,7 +230,7 @@ public function it_can_get_the_correct_url_for_route_type()
229230
$sub->route('settings.account', 'Account');
230231
});
231232
$children = $menuItem->getChilds()[0]->getChilds();
232-
$childMenuItem = array_first($children);
233+
$childMenuItem = Arr::first($children);
233234

234235
$this->assertEquals('http://localhost/settings/account', $childMenuItem->getUrl());
235236
}

Tests/MenuTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public function it_gets_a_partial_for_dropdown_styles()
9696
$this->menu->create('test', function (MenuBuilder $menu) {
9797
});
9898

99-
$this->assertContains('.dropdown-submenu', $this->menu->style());
99+
$this->assertStringContainsString('.dropdown-submenu', $this->menu->style());
100100
}
101101

102102
/** @test */

composer.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,16 @@
2121
],
2222
"require": {
2323
"php": ">=7.1",
24-
"illuminate/support": "5.8.*",
25-
"illuminate/config": "5.8.*",
26-
"illuminate/view": "5.8.*",
27-
"laravelcollective/html": "5.8.*.*"
24+
"illuminate/support": "^6.0",
25+
"illuminate/config": "^6.0",
26+
"illuminate/view": "^6.0",
27+
"laravelcollective/html": "6.0.*"
2828
},
2929
"require-dev": {
30-
"phpunit/phpunit": "^7.3",
31-
"mockery/mockery": "^1.0",
32-
"orchestra/testbench": "3.8.*",
33-
"friendsofphp/php-cs-fixer": "^2.10"
30+
"phpunit/phpunit": "^8.0",
31+
"mockery/mockery": "~1.0",
32+
"orchestra/testbench": "^4.0",
33+
"friendsofphp/php-cs-fixer": "^2.15"
3434
},
3535
"autoload": {
3636
"psr-4": {
@@ -44,7 +44,7 @@
4444
},
4545
"extra": {
4646
"branch-alias": {
47-
"dev-master": "4.0-dev"
47+
"dev-master": "5.0-dev"
4848
},
4949
"laravel": {
5050
"providers": [

src/MenuItem.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Closure;
66
use Collective\Html\HtmlFacade as HTML;
77
use Illuminate\Contracts\Support\Arrayable as ArrayableContract;
8+
use Illuminate\Support\Arr;
89
use Illuminate\Support\Facades\Request;
910

1011
/**
@@ -79,11 +80,11 @@ public function __construct($properties = array())
7980
*/
8081
protected static function setIconAttribute(array $properties)
8182
{
82-
$icon = array_get($properties, 'attributes.icon');
83+
$icon = Arr::get($properties, 'attributes.icon');
8384
if (!is_null($icon)) {
8485
$properties['icon'] = $icon;
8586

86-
array_forget($properties, 'attributes.icon');
87+
Arr::forget($properties, 'attributes.icon');
8788

8889
return $properties;
8990
}
@@ -381,7 +382,7 @@ public function getAttributes()
381382
{
382383
$attributes = $this->attributes ? $this->attributes : [];
383384

384-
array_forget($attributes, ['active', 'icon']);
385+
Arr::forget($attributes, ['active', 'icon']);
385386

386387
return HTML::attributes($attributes);
387388
}

0 commit comments

Comments
 (0)