Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Commit 7c69f00

Browse files
Bug 22988461 - INCORRECT CALCULATION FOR PAGES_HASHED, PAGES_OLD
Remove the check of wether the percentage of old pages found in the sys schema views is less that @@global.innodb_old_blocks_pct as it's too unstable due to randomness of the data.
1 parent bb13ac9 commit 7c69f00

File tree

4 files changed

+0
-34
lines changed

4 files changed

+0
-34
lines changed

mysql-test/suite/sysschema/r/v_innodb_buffer_stats_by_schema.result

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,3 @@ pages_hashed bigint(21) NO 0
1818
pages_old bigint(21) NO 0
1919
rows_cached decimal(44,0) NO 0
2020
SELECT * FROM sys.x$innodb_buffer_stats_by_schema;
21-
SELECT (SUM(pages_old)/sum(pages)*100 < (@@global.innodb_old_blocks_pct + 3)) AS OldPagesSmallEnough
22-
FROM sys.innodb_buffer_stats_by_schema;
23-
OldPagesSmallEnough
24-
1
25-
SELECT (SUM(pages_old)/sum(pages)*100 < (@@global.innodb_old_blocks_pct + 3)) AS OldPagesSmallEnough
26-
FROM sys.x$innodb_buffer_stats_by_schema;
27-
OldPagesSmallEnough
28-
1

mysql-test/suite/sysschema/r/v_innodb_buffer_stats_by_table.result

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,3 @@ pages_hashed bigint(21) NO 0
2020
pages_old bigint(21) NO 0
2121
rows_cached decimal(44,0) NO 0
2222
SELECT * FROM sys.x$innodb_buffer_stats_by_table;
23-
SELECT (SUM(pages_old)/sum(pages)*100 < (@@global.innodb_old_blocks_pct + 3)) AS OldPagesSmallEnough
24-
FROM sys.innodb_buffer_stats_by_table;
25-
OldPagesSmallEnough
26-
1
27-
SELECT (SUM(pages_old)/sum(pages)*100 < (@@global.innodb_old_blocks_pct + 3)) AS OldPagesSmallEnough
28-
FROM sys.x$innodb_buffer_stats_by_table;
29-
OldPagesSmallEnough
30-
1

mysql-test/suite/sysschema/t/v_innodb_buffer_stats_by_schema.test

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,3 @@ DESC sys.x$innodb_buffer_stats_by_schema;
1919
--disable_result_log
2020
SELECT * FROM sys.x$innodb_buffer_stats_by_schema;
2121
--enable_result_log
22-
23-
24-
# Check that the old pages percentage is smaller than @@global.innodb_old_blocks_pct
25-
# Add 3 percent to avoid false positives due to rounding errors
26-
SELECT (SUM(pages_old)/sum(pages)*100 < (@@global.innodb_old_blocks_pct + 3)) AS OldPagesSmallEnough
27-
FROM sys.innodb_buffer_stats_by_schema;
28-
29-
SELECT (SUM(pages_old)/sum(pages)*100 < (@@global.innodb_old_blocks_pct + 3)) AS OldPagesSmallEnough
30-
FROM sys.x$innodb_buffer_stats_by_schema;

mysql-test/suite/sysschema/t/v_innodb_buffer_stats_by_table.test

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,3 @@ DESC sys.x$innodb_buffer_stats_by_table;
1919
--disable_result_log
2020
SELECT * FROM sys.x$innodb_buffer_stats_by_table;
2121
--enable_result_log
22-
23-
24-
# Check that the old pages percentage is smaller than @@global.innodb_old_blocks_pct
25-
# Add 3 percent to avoid false positives due to rounding errors
26-
SELECT (SUM(pages_old)/sum(pages)*100 < (@@global.innodb_old_blocks_pct + 3)) AS OldPagesSmallEnough
27-
FROM sys.innodb_buffer_stats_by_table;
28-
29-
SELECT (SUM(pages_old)/sum(pages)*100 < (@@global.innodb_old_blocks_pct + 3)) AS OldPagesSmallEnough
30-
FROM sys.x$innodb_buffer_stats_by_table;

0 commit comments

Comments
 (0)