Skip to content

Commit 216a7da

Browse files
committed
Database version changed to last stable, Fix:erase EEPROM
1 parent 39c6433 commit 216a7da

File tree

7 files changed

+37
-8
lines changed

7 files changed

+37
-8
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
<version.org.jboss.resteasy>3.0.11.Final</version.org.jboss.resteasy>
6161
<version.javax.servlet>2.5</version.javax.servlet>
6262
<version.com.j256.ormlite>4.48</version.com.j256.ormlite>
63-
<version.com.h2database>1.4.185</version.com.h2database>
63+
<version.com.h2database>1.3.176</version.com.h2database>
6464
<version.com.xeiam>2.0.1-SNAPSHOT</version.com.xeiam>
6565
<version.commons-lang>2.2</version.commons-lang>
6666
<version.com.luckycatlabs>1.2</version.com.luckycatlabs>

src/main/java/org/mycontroller/standalone/db/alarm/ExecuteAlarm.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public void runAlarm(Alarm alarm) throws Exception {
129129

130130
private void alarmTriggerCall(Alarm alarm, boolean triggerAlarm) throws Exception {
131131
if (triggerAlarm) {
132-
if (!alarm.getTriggered()) {
132+
if (!alarm.getTriggered() || !alarm.getIgnoreDuplicate()) {
133133
switch (AlarmUtils.TYPE.get(alarm.getType())) {
134134
case SEND_PAYLOAD:
135135
alarmSendPayLoad(alarm);

src/main/java/org/mycontroller/standalone/db/tables/Alarm.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ public Alarm() {
5454
@DatabaseField(canBeNull = true)
5555
private Long lastTrigger;
5656

57+
@DatabaseField(canBeNull = true, defaultValue = "true")
58+
private Boolean ignoreDuplicate;
59+
5760
@DatabaseField(canBeNull = true)
5861
private Long lastNotification;
5962

@@ -309,4 +312,12 @@ public void setEvaluationCount(Integer evaluationCount) {
309312
this.evaluationCount = evaluationCount;
310313
}
311314

315+
public Boolean getIgnoreDuplicate() {
316+
return ignoreDuplicate;
317+
}
318+
319+
public void setIgnoreDuplicate(Boolean ignoreDuplicate) {
320+
this.ignoreDuplicate = ignoreDuplicate;
321+
}
322+
312323
}

src/main/java/org/mycontroller/standalone/mysensors/ProcessRawMessage.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ private void processFirmwareConfigRequest(RawMessage rawMessage) {
388388
FirmwareConfigResponse firmwareConfigResponse = new FirmwareConfigResponse();
389389
firmwareConfigResponse.setByteBufferPosition(0);
390390

391-
if (bootLoaderCommand) {
391+
if (bootLoaderCommand) {//If it is bootloader command
392392
if (node.getEraseEEPROM() != null && node.getEraseEEPROM()) {
393393
firmwareConfigResponse.loadEraseEepromCommand();
394394
node.setEraseEEPROM(false); //Remove erase EEPROM flag and update in to database
@@ -398,7 +398,7 @@ private void processFirmwareConfigRequest(RawMessage rawMessage) {
398398
firmwareConfigRequest);
399399
return;
400400
}
401-
} else if (firmware == null) {
401+
} else if (firmware == null) {//Non bootloader command
402402
if (DaoUtils.getSettingsDao().get(Settings.ENABLE_NOT_AVAILABLE_TO_DEFAULT_FIRMWARE).getValue()
403403
.equalsIgnoreCase("true")) {
404404
_logger.debug("If requested firmware is not available, redirect to default firmware is set, Checking the default firmware");
@@ -410,12 +410,15 @@ private void processFirmwareConfigRequest(RawMessage rawMessage) {
410410
_logger.warn("There is no default firmware set!");
411411
}
412412
}
413+
//Selected, default: No firmware available for this request
414+
if (firmware == null) {
415+
_logger.warn("Selected Firmware is not available, FirmwareConfigRequest:[{}]",
416+
firmwareConfigRequest);
417+
return;
418+
}
413419
}
414420

415-
if (firmware == null) {
416-
_logger.warn("Selected Firmware is not available, FirmwareConfigRequest:[{}]", firmwareConfigRequest);
417-
return;
418-
} else {
421+
if (firmware != null) {
419422
firmwareConfigResponse.setType(firmware.getType().getId());
420423
firmwareConfigResponse.setVersion(firmware.getVersion().getId());
421424
firmwareConfigResponse.setBlocks(firmware.getBlocks());

src/main/package/www/controllers/alarm.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ myControllerModule.controller('AMaddController', function ($scope, $modalInstanc
137137
$scope.alarm.sensor = {};
138138
$scope.alarm.sensor.node = {};
139139
$scope.alarm.sensor.id = sensor.id;
140+
$scope.alarm.ignoreDuplicate = true;
140141
$scope.header = "Add Alarm for '"+sensor.nameWithNode+"'";
141142
$scope.alarmNotifications = TypesFactory.getAlarmTypes();
142143
$scope.sensorvalueTypes = TypesFactory.getSensorValueTypes();

src/main/package/www/partials/alarm/addModal.html

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,13 @@ <h4>{{header}}</h4>
4141
</div>
4242
</div>
4343

44+
<div class="form-group">
45+
<label class=" control-label col-sm-3 checkbox">Ignore Duplicate</label>
46+
<div class="col-sm-6">
47+
<input type="checkbox" ng-model="alarm.ignoreDuplicate">
48+
</div>
49+
</div>
50+
4451
<legend></legend>
4552

4653
<div class="form-group">

src/main/package/www/partials/alarm/updateModal.html

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,13 @@ <h4>{{header}}</h4>
4141
</div>
4242
</div>
4343

44+
<div class="form-group">
45+
<label class=" control-label col-sm-3 checkbox">Ignore Duplicate</label>
46+
<div class="col-sm-6">
47+
<input type="checkbox" ng-model="alarm.ignoreDuplicate">
48+
</div>
49+
</div>
50+
4451
<legend></legend>
4552

4653
<div class="form-group">

0 commit comments

Comments
 (0)