Rule to enforce a test has tags

[seanlafferty-ibm]

We currently use tags as a way to control what environment a test gets ran in, so we require all tests have tags. However, I don't believe this is enforceable by a lint rule.

I can config the tag rule like:

"playwright/valid-test-tags": [
  "error",
  { allowedTags: ["@saas", "@onprem"] },
],

but that still permits a test like test("Im a test with no tags"). Any thoughts about this? Perhaps a allowTestsWithoutTags bool option for this rule?

I suppose there could be some nuance in that a test() inherits the tags of its parent describe() block, so if this rule did exist, we'd have to decide if we want do the recursion to make

describe("parent @tag1")
  test("child")

permissable, or just have the rule operate naively on test() calls.

[MSroczynski3]

Hi @seanlafferty-ibm ,
In my view, this functionality should be a separate rule. Putting a flag inside valid-test-tags would obfuscate the purpose. Good point about inheriting tags from the describe() block. This might get tricky. I guess the new rule could crawl up to search for the tags in the main node.

[mskelton]

I mostly agree with @MSroczynski3 that a new rule makes the most sense here. Dealing with nested describes shouldn't be horrible (we have utils for digging up and down the AST).