Skip to content

Commit ba6b5c4

Browse files
author
mreishman
committed
added verification check for consec success saves
1 parent d13c58e commit ba6b5c4

File tree

12 files changed

+74
-29
lines changed

12 files changed

+74
-29
lines changed

core/conf/config.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
'blockGitCommitDiff' => 'false',
2525
'blockGitCommitHistory' => 'false',
2626
'blockGitShowCommitStuff' => 'false',
27+
'successVerifyNum' => 3,
2728
'defaultBranchList' => 'master',
2829
'errorAndColorArray' => array(
2930
'error' => array(

core/html/changelog.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
Features
77
<ul>
88
<li>
9-
Added option for custom git url
9+
Added option for custom git url
10+
</li>
11+
<li>
12+
Buttons to move watchlist blocks up / down
1013
</li>
1114
</ul>
1215
</li>
@@ -22,6 +25,9 @@
2225
<li>
2326
Fixed bug where adding a new server / removing a server would show dropdown inputs as text field inputs
2427
</li>
28+
<li>
29+
Added consecutive save verify check on saves
30+
</li>
2531
</ul>
2632
</li>
2733
</ul>

core/js/settingsAll.js

Lines changed: 36 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
var modiferUrl = "";
2+
var countForVerifySave = 0;
3+
var countForVerifySaveSuccess = 0;
4+
var successVerifyNum = 3;
25

36
function saveAndVerifyMain(idForForm, modifier = "")
47
{
@@ -23,6 +26,7 @@ function saveAndVerifyMain(idForForm, modifier = "")
2326
function verifySaveTimer()
2427
{
2528
countForVerifySave = 0;
29+
countForVerifySaveSuccess = 0;
2630
pollCheckForUpdate = setInterval(timerVerifySave,3000);
2731
}
2832

@@ -42,28 +46,16 @@ function timerVerifySave()
4246
{
4347
if(data === true)
4448
{
45-
clearInterval(pollCheckForUpdate);
46-
if(idForFormMain === "settingsMainWatch")
49+
countForVerifySaveSuccess++;
50+
if(countForVerifySaveSuccess >= successVerifyNum)
4751
{
48-
showPopupForCacheClear = false;
49-
clearCache();
50-
}
51-
else
52-
{
53-
if(document.getElementsByName("pollType")[0])
54-
{
55-
if(document.getElementsByName("pollType")[0].value !== "2")
56-
{
57-
document.getElementById("menuBarLeftSettingsServerWatchList").style.display = "none";
58-
}
59-
else
60-
{
61-
document.getElementById("menuBarLeftSettingsServerWatchList").style.display = "block";
62-
}
63-
}
64-
saveVerified();
52+
verifySuccess();
6553
}
6654
}
55+
else
56+
{
57+
countForVerifySaveSuccess = 0;
58+
}
6759
},
6860
});
6961
}
@@ -74,6 +66,31 @@ function timerVerifySave()
7466
}
7567
}
7668

69+
function verifySuccess()
70+
{
71+
clearInterval(pollCheckForUpdate);
72+
if(idForFormMain === "settingsMainWatch")
73+
{
74+
showPopupForCacheClear = false;
75+
clearCache();
76+
}
77+
else
78+
{
79+
if(document.getElementsByName("pollType")[0])
80+
{
81+
if(document.getElementsByName("pollType")[0].value !== "2")
82+
{
83+
document.getElementById("menuBarLeftSettingsServerWatchList").style.display = "none";
84+
}
85+
else
86+
{
87+
document.getElementById("menuBarLeftSettingsServerWatchList").style.display = "block";
88+
}
89+
}
90+
saveVerified();
91+
}
92+
}
93+
7794
function saveVerified()
7895
{
7996
saveSuccess();

core/php/templateFiles/devBoxSettings.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,16 @@
5454
</li>
5555
</ul>
5656
</li>
57+
<li>
58+
Save Success Num:
59+
<select name="successVerifyNum">
60+
<option <?php if($successVerifyNum == 1){echo "selected";} ?> value="1">1</option>
61+
<option <?php if($successVerifyNum == 2){echo "selected";} ?> value="2">2</option>
62+
<option <?php if($successVerifyNum == 3){echo "selected";} ?> value="3">3</option>
63+
<option <?php if($successVerifyNum == 4){echo "selected";} ?> value="4">4</option>
64+
<option <?php if($successVerifyNum == 5){echo "selected";} ?> value="5">5</option>
65+
</select>
66+
</li>
5767
</ul>
5868
</div>
5969
</div>

settings-watchList.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ function saveWatchList(post)
112112
<?php
113113
echo "var currentVersion = '".$configStatic['version']."';";
114114
?>
115+
var successVerifyNum = <?php echo $successVerifyNum; ?>;
115116
</script>
116117
<script src="core/js/allPages.js?v=<?php echo $configStatic['version']; ?>"></script>
117118
<script src="core/js/cacheClear.js?v=<?php echo $configStatic['version']; ?>"></script>

settings-watchListServer.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ function saveWatchList(post)
112112
<?php
113113
echo "var currentVersion = '".$configStatic['version']."';";
114114
?>
115+
var successVerifyNum = <?php echo $successVerifyNum; ?>;
115116
</script>
116117
<script src="core/js/allPages.js?v=<?php echo $configStatic['version']; ?>"></script>
117118
<script src="core/js/settingsAll.js?v=<?php echo $configStatic['version']; ?>"></script>

settings.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
var counfOfFiltersForbranchName = <?php echo $counfOfFiltersForbranchName; ?>;
7373
var counfOfFiltersForAuthorName = <?php echo $counfOfFiltersForAuthorName; ?>;
7474
var counfOfFiltersForComitteeName = <?php echo $counfOfFiltersForComitteeName; ?>;
75+
var successVerifyNum = <?php echo $successVerifyNum; ?>;
7576

7677
function calcuateWidth()
7778
{

setup/step1.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function clean_url($url) {
1414
}
1515

1616

17-
require_once($baseUrl.'conf/config.php');
17+
require_once($baseUrl.'conf/config.php');
1818
require_once('setupProcessFile.php');
1919

2020
if($setupProcess != "step1")
@@ -49,7 +49,7 @@ function clean_url($url) {
4949
</style>
5050
</head>
5151
<body>
52-
<?php readfile('../core/html/popup.html') ?>
52+
<?php readfile('../core/html/popup.html') ?>
5353
<div class="firstBoxDev" style="width: 90%; margin: auto; margin-right: auto; margin-left: auto; display: block; height: auto; margin-top: 15px;" >
5454
<div class="devBoxTitle">
5555
<h1>Step 1 of <?php echo $counterSteps; ?></h1>
@@ -98,6 +98,7 @@ function clean_url($url) {
9898
</body>
9999
<form id="defaultVarsForm" action="../core/php/saveFunctions/settingsSaveMain.php" method="post"></form>
100100
<script type="text/javascript">
101+
var successVerifyNum = <?php echo $successVerifyNum; ?>;
101102

102103
function updateStatusCustom()
103104
{

setup/step2.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ function clean_url($url) {
7272
</body>
7373
<form id="defaultVarsForm" action="../core/php/saveFunctions/settingsSaveMain.php" method="post"></form>
7474
<script type="text/javascript">
75+
var successVerifyNum = <?php echo $successVerifyNum; ?>;
76+
7577
function defaultSettings()
7678
{
7779
//change setupProcess to finished

setup/step3.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ function clean_url($url) {
7272
</body>
7373
<form id="defaultVarsForm" action="../core/php/saveFunctions/settingsSaveMain.php" method="post"></form>
7474
<script type="text/javascript">
75+
var successVerifyNum = <?php echo $successVerifyNum; ?>;
76+
7577
function defaultSettings()
7678
{
7779
//change setupProcess to finished

0 commit comments

Comments
 (0)