Skip to content

Commit 8f8fb33

Browse files
authored
Merge pull request #223 from mreishman/4.1.1
4.1.1
2 parents 1fb2549 + 5914b1c commit 8f8fb33

File tree

11 files changed

+100
-7
lines changed

11 files changed

+100
-7
lines changed

core/conf/config.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
'enableSystemPrefShellOrPhp' => 'false',
1616
'expSettingsAvail' => 'true',
1717
'defaultViewBranch' => 'Standard',
18+
'defaultExpandTab' => 'info',
1819
'cacheEnabled' => 'true',
1920
'dontNotifyVersion' => '0',
2021
'onlyRefreshVisible' => 'true',

core/html/changelog.html

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,28 @@
11
<ul>
2+
<li>
3+
Version 4.1.1
4+
<ul>
5+
<li>
6+
Features
7+
<ul>
8+
<li>
9+
Added option to select default open tab in expanded info window
10+
</li>
11+
</ul>
12+
</li>
13+
<li>
14+
Bug Fixes
15+
<ul>
16+
<li>
17+
Font style change for updater
18+
</li>
19+
<li>
20+
Created tabs for watchlist settings, more servers are now visible on one screen
21+
</li>
22+
</ul>
23+
</li>
24+
</ul>
25+
</li>
226
<li>
327
Version 4.1
428
<ul>

core/js/main.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1839,7 +1839,13 @@ function toggleDetailBar(e, key)
18391839
}
18401840
else
18411841
{
1842-
toggleInfoTab();
1842+
if(defaultExpandTab === "info")
1843+
{
1844+
toggleInfoTab();
1845+
}
1846+
else if(defaultExpandTab === "commits") {
1847+
toggleCommitsTab();
1848+
}
18431849
}
18441850
}
18451851

core/js/watchlist.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,18 @@ function checkWebsiteStatus(sendUrlHere)
250250
});
251251
}
252252

253+
function toggleSettingsGroupSection(number, type)
254+
{
255+
$("#"+number+"General").hide();
256+
$("#"+number+"GeneralButton").removeClass("selected");
257+
$("#"+number+"Git").hide();
258+
$("#"+number+"GitButton").removeClass("selected");
259+
$("#"+number+"Advanced").hide();
260+
$("#"+number+"AdvancedButton").removeClass("selected");
261+
$("#"+number+type).show();
262+
$("#"+number+type+"Button").addClass("selected");
263+
}
264+
253265
$( document ).ready(function() {
254266
hideLastMoveDownButton();
255267
});

core/php/configStatic.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<?php
33

44
$configStatic = array(
5-
'version' => '4.1',
5+
'version' => '4.1.1',
66
'lastCheck' => '12-14-2018',
77
'newestVersion' => '3.3.4',
88
'versionList' => array(

core/php/functions/watchlistFunctions.php

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,37 @@ function generateWatchlistBlock($defaultArray, $arrayKeys, $key = "{{key}}", $it
1818
<span class=\"leftSpacingserverNames\" > Name: </span>
1919
<input class='inputWidth300' type='text' name='watchListKey" . $i . "' value='" . $key . "'>";
2020
$j = 0;
21+
$stringToReturn .= "<div style=\"border-bottom: 1px solid black; margin-bottom: 5px; padding: 5px;\">";
22+
if(count($defaultArray) > 1)
23+
{
24+
$selectedOption = false;
25+
foreach($defaultArray as $groupName => $groupData)
26+
{
27+
$stringToReturn .= "<span id=\"".$i.$groupName."Button\" class=\"buttonButton ";
28+
if(!$selectedOption)
29+
{
30+
$stringToReturn .= " selected ";
31+
$selectedOption = true;
32+
}
33+
$stringToReturn .= " \" style=\"margin-right: 5px;\" onclick=\"toggleSettingsGroupSection('".$i."','".$groupName."');\" >".$groupName."</span>";
34+
}
35+
}
36+
else
37+
{
38+
foreach($defaultArray as $groupName => $groupData)
39+
{
40+
$stringToReturn .= "<h4 style=\"margin: 5px;\">".$groupName."</h4>";
41+
}
42+
}
43+
$stringToReturn .= "</div>";
2144
foreach($defaultArray as $groupName => $groupData)
2245
{
23-
if($groupName !== "")
46+
$stringToReturn .= "<span id=\"".$i.$groupName."\" ";
47+
if($j !== 0)
2448
{
25-
$stringToReturn .= "<div style=\"border-bottom: 1px solid black; margin-bottom: 5px;\">
26-
<h4 style=\"margin: 5px;\">".$groupName."</h4>
27-
</div>";
49+
$stringToReturn .= " style=\"display: none;\" ";
2850
}
51+
$stringToReturn .= " >";
2952
$brCount = 0;
3053
foreach($groupData as $key2 => $item2)
3154
{
@@ -148,6 +171,7 @@ function generateWatchlistBlock($defaultArray, $arrayKeys, $key = "{{key}}", $it
148171
$stringToReturn .= "'>";
149172
}
150173
}
174+
$stringToReturn .= "</span>";
151175
}
152176
$stringToReturn .= "
153177
<input style=\"display: none\" type=\"text\" name=\"watchListItem" . $i . "-0\" value='" . $j . "'>

core/php/templateFiles/settingsMain.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,17 @@
107107
</td>
108108
</tr>
109109
<?php endif; ?>
110+
<tr>
111+
<td>
112+
Default Expand Tab
113+
</td>
114+
<td>
115+
<select name="defaultExpandTab">
116+
<option <?php if($defaultExpandTab == 'info'){echo "selected";} ?> value="info">Info</option>
117+
<option <?php if($defaultExpandTab == 'commits'){echo "selected";} ?> value="commits">Commits</option>
118+
</select>
119+
</td>
120+
</tr>
110121
</table>
111122
</div>
112123
</div>

core/template/theme.css

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,13 @@ input {
502502
border: 1px solid #999;
503503
}
504504

505+
.buttonButton.selected {
506+
background-color: #555;
507+
color: white;
508+
border: 1px solid #777;
509+
cursor: default;
510+
}
511+
505512
.noticeMessage{
506513
background-color: white;
507514
width: 100%;

index.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@
411411
echo "var maxCommits = ".$maxCommits.";";
412412
echo "var onServerRemoveRemoveNotError = ".$onServerRemoveRemoveNotError.";";
413413
echo "var defaultBranchList = '".$defaultBranchList."';";
414+
echo "var defaultExpandTab = '".$defaultExpandTab."';";
414415
if(empty($cachedStatusMainObject))
415416
{
416417
echo "var arrayOfWatchFilters = {};";

local/default/template/theme.css

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,13 @@ input {
502502
border: 1px solid #999;
503503
}
504504

505+
.buttonButton.selected {
506+
background-color: #555;
507+
color: white;
508+
border: 1px solid #777;
509+
cursor: default;
510+
}
511+
505512
.noticeMessage{
506513
background-color: white;
507514
width: 100%;

0 commit comments

Comments
 (0)