ci: bump node versions (#3428)

FTR `shell` needs to be set to `true` since https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2, because it refuses to load `.bat` files on Windows otherwise.

Author: willdurand

.circleci/config.yml

@@ -28,9 +28,9 @@ references:
   # See https://nodejs.org/en/about/previous-releases for updates to nodejs versions.
   nodejs_versions:
     # nvm-windows wants a full Node version, not just `<major>.<minor>`.
-    - &nodejs_current "18.19.0"
-    - &nodejs_next "20.11.0"
-    - &nodejs_experimental "21.5"
+    - &nodejs_current "20.19.5"
+    - &nodejs_next "22.19"
+    - &nodejs_experimental "24.8"
 
   nodejs_enum: &nodejs_enum
     type: enum

scripts/lib/mocha.js

@@ -29,6 +29,8 @@ const runMocha = (args, execMochaOptions = {}, coverageEnabled) => {
       NODE_ENV: 'test',
     },
     stdio: 'inherit',
+    // See: https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows
+    shell: process.platform === 'win32',
   });
 
   if (res.error) {

tests/functional/test.lib.imports.js

@@ -7,7 +7,10 @@ import shell from 'shelljs';
 
 import { withTempDir, fixturesUseAsLibrary } from './common.js';
 
-const npm = shell.which('npm')?.toString();
+let npm = shell.which('npm')?.toString();
+if (process.platform === 'win32') {
+  npm = `"${npm}"`;
+}
 const node = shell.which('node')?.toString();
 
 const dirname = path.dirname(fileURLToPath(import.meta.url || ''));
@@ -29,6 +32,8 @@ describe('web-ext imported as a library', () => {
       execFileSync(npm, ['install', packageDir], {
         cwd: tmpDir.path(),
         stdio: 'inherit',
+        // See: https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows
+        shell: process.platform === 'win32',
       });
       shell.cp('-rf', `${fixturesUseAsLibrary}/*`, tmpDir.path());
       execFileSync(node, ['--experimental-modules', 'test-import.mjs'], {
@@ -39,7 +44,11 @@ describe('web-ext imported as a library', () => {
 
   it('can be imported as a CommonJS module', async () => {
     await withTempDir(async (tmpDir) => {
-      execFileSync(npm, ['install', packageDir], { cwd: tmpDir.path() });
+      execFileSync(npm, ['install', packageDir], {
+        cwd: tmpDir.path(),
+        // See: https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows
+        shell: process.platform === 'win32',
+      });
       shell.cp('-rf', `${fixturesUseAsLibrary}/*`, tmpDir.path());
       execFileSync(node, ['--experimental-modules', 'test-require.js'], {
         cwd: tmpDir.path(),