PYTHON-4540 Cleaner separation of test lifecycle #2082
Conversation
NoahStapp
left a comment
NoahStapp
left a comment
There was a problem hiding this comment.
Incredible work, I'm weeping with joy.
| tags = ["load-balancer", auth, ssl] | ||
| bootstrap_vars = dict(TOPOLOGY="sharded_cluster", AUTH=auth, SSL=ssl, LOAD_BALANCER="true") | ||
| bootstrap_func = FunctionCall(func="bootstrap mongo-orchestration", vars=bootstrap_vars) | ||
| balancer_func = FunctionCall(func="run load-balancer") |
There was a problem hiding this comment.
Intentional removal of balancer_func?
There was a problem hiding this comment.
Yes, it was absorbed into setup_test.py
| else | ||
| _BIN_DIR=$HOME/.local/bin | ||
| HERE=$(dirname ${BASH_SOURCE:-$0}) | ||
| pushd "$(dirname "$(dirname $HERE)")" > /dev/null |
| UV_ARGS.append(f"--extra {extra}") | ||
|
|
||
| for env_var, suite in TEST_SUITE_MAP.items(): | ||
| if TEST_SUITES: |
There was a problem hiding this comment.
So this loop sets TEST_SUITES equal to the first encountered suite?
There was a problem hiding this comment.
That or if the environment variable was set
There was a problem hiding this comment.
Does it make more sense to have the continue to be a break then?
.evergreen/scripts/setup-tests.py
Outdated
|
|
||
| if AUTH != "noauth": | ||
| if is_set("TEST_DATA_LAKE"): | ||
| DB_USER = "mhuser" |
There was a problem hiding this comment.
Should we save these into environment variables in our secrets?
There was a problem hiding this comment.
I scheduled an ADL test for the latest commit
NoahStapp
left a comment
NoahStapp
left a comment
There was a problem hiding this comment.
LGTM assuming the tests pass. Thanks a ton, Steve!
2 participants
run-tests.shinto a setup phase and a test run phaseuvenvironment and thepytestinvocation.setup-tests.py.Follow up PRs will move more of the "other" tests such as Auth AWS and Auth OIDC into this centralized pattern of
just setup-testandjust test-eg.Scheduled a cross-section of tasks for this build: https://spruce.mongodb.com/version/67abd5b92d7b8f00078f297b/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC