BinaryVector is no longer a dataclass. Instead, we implement __eq__

Author: caseyclements

bson/binary.py

@@ -14,7 +14,6 @@
 from __future__ import annotations
 
 import struct
-from dataclasses import dataclass
 from enum import Enum
 from typing import TYPE_CHECKING, Any, Optional, Sequence, Tuple, Type, Union, overload
 from uuid import UUID
@@ -227,7 +226,6 @@ class BinaryVectorDtype(Enum):
     PACKED_BIT = b"\x10"
 
 
-@dataclass
 class BinaryVector:
     """Vector of numbers along with metadata for binary interoperability.
     .. versionadded:: 4.10
@@ -250,6 +248,13 @@ def __init__(self, data: Sequence[float | int], dtype: BinaryVectorDtype, paddin
     def __repr__(self) -> str:
         return f"BinaryVector(dtype={self.dtype}, padding={self.padding}, data={self.data})"
 
+    def __eq__(self, other: BinaryVector) -> bool:
+        if not isinstance(other, BinaryVector):
+            return False
+        return (
+            self.dtype == other.dtype and self.padding == other.padding and self.data == other.data
+        )
+
 
 class Binary(bytes):
     """Representation of BSON binary data.

test/test_bson.py

@@ -849,6 +849,24 @@ def test_binaryvector_repr(self):
         )
         self.assertRepr(zero)
 
+    def test_binaryvector_equality(self):
+        """Tests of == __eq__"""
+        self.assertEqual(
+            BinaryVector([1.2, 1 - 1 / 3], BinaryVectorDtype.FLOAT32, 0),
+            BinaryVector([1.2, 1 - 1.0 / 3.0], BinaryVectorDtype.FLOAT32, 0),
+        )
+        self.assertNotEqual(
+            BinaryVector([1.2, 1 - 1 / 3], BinaryVectorDtype.FLOAT32, 0),
+            BinaryVector([1.2, 6.0 / 9.0], BinaryVectorDtype.FLOAT32, 0),
+        )
+        self.assertEqual(
+            BinaryVector([], BinaryVectorDtype.FLOAT32, 0),
+            BinaryVector([], BinaryVectorDtype.FLOAT32, 0),
+        )
+        self.assertNotEqual(
+            BinaryVector([1], BinaryVectorDtype.INT8), BinaryVector([2], BinaryVectorDtype.INT8)
+        )
+
     def test_unicode_regex(self):
         """Tests we do not get a segfault for C extension on unicode RegExs.
         This had been happening.