address review

Author: blink1073

pymongo/asynchronous/pool.py

@@ -52,6 +52,7 @@
     DocumentTooLarge,
     ExecutionTimeout,
     InvalidOperation,
+    NetworkTimeout,
     NotPrimaryError,
     OperationFailure,
     PyMongoError,
@@ -1025,7 +1026,7 @@ async def remove_stale_sockets(self, reference_generation: int) -> None:
     def _handle_connection_error(self, error: BaseException) -> None:
         # Handle system overload condition for non-sdam pools.
         # Look for errors of type AutoReconnect and add error labels if appropriate.
-        if self.is_sdam or type(error) != AutoReconnect:
+        if self.is_sdam or type(error) not in (AutoReconnect, NetworkTimeout):
             return
         error._add_error_label("SystemOverloadedError")
         error._add_error_label("RetryableError")

pymongo/synchronous/pool.py

@@ -49,6 +49,7 @@
     DocumentTooLarge,
     ExecutionTimeout,
     InvalidOperation,
+    NetworkTimeout,
     NotPrimaryError,
     OperationFailure,
     PyMongoError,
@@ -1021,7 +1022,7 @@ def remove_stale_sockets(self, reference_generation: int) -> None:
     def _handle_connection_error(self, error: BaseException) -> None:
         # Handle system overload condition for non-sdam pools.
         # Look for errors of type AutoReconnect and add error labels if appropriate.
-        if self.is_sdam or type(error) != AutoReconnect:
+        if self.is_sdam or type(error) not in (AutoReconnect, NetworkTimeout):
             return
         error._add_error_label("SystemOverloadedError")
         error._add_error_label("RetryableError")

test/asynchronous/test_pooling.py

@@ -517,7 +517,7 @@ async def test_connection_timeout_message(self):
     @async_client_context.require_failCommand_appName
     async def test_pool_backpressure_preserves_existing_connections(self):
         client = await self.async_rs_or_single_client()
-        coll = self.db.t
+        coll = client.pymongo_test.t
         pool = await async_get_pool(client)
         await coll.insert_many([{"x": 1} for _ in range(10)])
         t = SocketGetter(self.c, pool)

test/test_pooling.py

@@ -515,7 +515,7 @@ def test_connection_timeout_message(self):
     @client_context.require_failCommand_appName
     def test_pool_backpressure_preserves_existing_connections(self):
         client = self.rs_or_single_client()
-        coll = self.db.t
+        coll = client.pymongo_test.t
         pool = get_pool(client)
         coll.insert_many([{"x": 1} for _ in range(10)])
         t = SocketGetter(self.c, pool)