fix: rename readReplLogfile to readReplLogFile and remove unnecessary log undefined check

Author: gagik

packages/cli-repl/src/cli-repl.spec.ts

@@ -18,7 +18,7 @@ import {
 import {
   expect,
   fakeTTYProps,
-  readReplLogfile,
+  readReplLogFile,
   tick,
   useTmpdir,
   waitBus,
@@ -56,7 +56,7 @@ describe('CliRepl', function () {
   async function log(): Promise<any[]> {
     if (!cliRepl.logWriter?.logFilePath) return [];
     await cliRepl.logWriter.flush(); // Ensure any pending data is written first
-    return readReplLogfile(cliRepl.logWriter.logFilePath);
+    return readReplLogFile(cliRepl.logWriter.logFilePath);
   }
 
   async function startWithExpectedImmediateExit(
@@ -1580,7 +1580,7 @@ describe('CliRepl', function () {
           input.write('db.hello()\n');
           input.write('exit\n');
           await waitBus(cliRepl.bus, 'mongosh:closed');
-          const flushEntry = (await readReplLogfile(logFilePath)).find(
+          const flushEntry = (await readReplLogFile(logFilePath)).find(
             (entry: any) => entry.id === 1_000_000_045
           );
           expect(flushEntry.attr.flushError).to.equal(null);

packages/cli-repl/test/repl-helpers.ts

@@ -87,7 +87,7 @@ const fakeTTYProps: Partial<ReadStream & WriteStream> = {
   },
 };
 
-async function readReplLogfile(
+async function readReplLogFile(
   logPath?: string | null | undefined
 ): Promise<any[]> {
   if (!logPath) return [];
@@ -107,5 +107,5 @@ export {
   waitEval,
   waitCompletion,
   fakeTTYProps,
-  readReplLogfile,
+  readReplLogFile,
 };

packages/e2e-tests/test/e2e-tls.spec.ts

@@ -5,7 +5,7 @@ import { startTestServer } from '../../../testing/integration-testing-hooks';
 import {
   useTmpdir,
   setTemporaryHomeDirectory,
-  readReplLogfile,
+  readReplLogFile,
   getCertPath,
   connectionStringWithLocalhost,
 } from './repl-helpers';
@@ -241,7 +241,7 @@ describe('e2e TLS', function () {
         expect(prompt.state).to.equal('prompt');
 
         const logPath = path.join(logBasePath, `${shell.logId}_log`);
-        const logContents = await readReplLogfile(logPath);
+        const logContents = await readReplLogFile(logPath);
         expect(
           logContents.find((line) => line.id.__value === 1_000_000_049)?.attr
             .asyncFallbackError
@@ -278,7 +278,7 @@ describe('e2e TLS', function () {
         expect(prompt.state).to.equal('prompt');
 
         const logPath = path.join(logBasePath, `${shell.logId}_log`);
-        const logContents = await readReplLogfile(logPath);
+        const logContents = await readReplLogFile(logPath);
         expect(
           logContents.find((line) => line.id.__value === 1_000_000_049)?.attr
             .asyncFallbackError
@@ -308,7 +308,7 @@ describe('e2e TLS', function () {
         expect(prompt.state).to.equal('exit');
 
         const logPath = path.join(logBasePath, `${shell.logId}_log`);
-        const logContents = await readReplLogfile(logPath);
+        const logContents = await readReplLogFile(logPath);
         expect(logContents.find((line) => line.id.__value === 1_000_000_049)).to
           .exist;
       });

packages/e2e-tests/test/e2e.spec.ts

@@ -14,7 +14,7 @@ import { promises as fs, createReadStream } from 'fs';
 import { promisify } from 'util';
 import path from 'path';
 import os from 'os';
-import { readReplLogfile, setTemporaryHomeDirectory } from './repl-helpers';
+import { readReplLogFile, setTemporaryHomeDirectory } from './repl-helpers';
 import { bson } from '@mongosh/service-provider-core';
 import type { Server as HTTPServer } from 'http';
 import { createServer as createHTTPServer } from 'http';
@@ -1398,7 +1398,7 @@ describe('e2e', function () {
           throw new Error('Shell does not have a logId associated with it');
         }
         const logPath = path.join(logBasePath, `${shell.logId}_log`);
-        return readReplLogfile<T>(logPath);
+        return readReplLogFile<T>(logPath);
       };
       startTestShell = async (...extraArgs: string[]) => {
         const shell = this.startTestShell({

packages/e2e-tests/test/repl-helpers.ts

@@ -49,7 +49,7 @@ function useTmpdir(): { readonly path: string } {
   };
 }
 
-async function readReplLogfile<T extends MongoLogEntry>(
+async function readReplLogFile<T extends MongoLogEntry>(
   logPath: string
 ): Promise<T[]> {
   return (await fs.readFile(logPath, 'utf8'))
@@ -165,7 +165,7 @@ async function connectionStringWithLocalhost(
 // eslint-disable-next-line mocha/no-exports
 export {
   useTmpdir,
-  readReplLogfile,
+  readReplLogFile,
   fakeExternalEditor,
   setTemporaryHomeDirectory,
   getCertPath,

packages/logging/src/logging-and-telemetry.ts

@@ -325,15 +325,13 @@ class LoggingAndTelemetry implements MongoshLoggingAndTelemetry {
         metadata: unknown;
       };
 
-      if (this.log) {
-        this.log[context === 'fatal' ? 'fatal' : 'error'](
-          'MONGOSH',
-          mongoLogId(1_000_000_006),
-          context,
-          `${mongoshError.name}: ${mongoshError.message}`,
-          error
-        );
-      }
+      this.log[context === 'fatal' ? 'fatal' : 'error'](
+        'MONGOSH',
+        mongoLogId(1_000_000_006),
+        context,
+        `${mongoshError.name}: ${mongoshError.message}`,
+        error
+      );
 
       if (error.name.includes('Mongosh')) {
         this.analytics.track({