fix(autocomplete): fix a semver check in old autocomplete (#2499)

* fix a semver check in old autocomplete

* add a test

* don't check the results

* print the whole error

* wait longer

* too much

Author: lerouxb

packages/autocomplete/src/index.spec.ts

@@ -497,6 +497,11 @@ describe('completer.completer', function () {
   });
 
   context('when context is aggregation query', function () {
+    it('returns all suggestions', async function () {
+      const i = 'db.shipwrecks.aggregate([{';
+      expect((await completer(standalone440, i))[0]).to.be.an('array');
+    });
+
     it('has several matches', async function () {
       const i = 'db.shipwrecks.aggregate([ { $so';
       expect(await completer(standalone440, i)).to.deep.equal([

packages/autocomplete/src/index.ts

@@ -290,6 +290,12 @@ export async function completer(
   return [[], line];
 }
 
+// from https://github.com/mongodb-js/devtools-shared/commit/e4a5b00a83b19a76bdf380799a421511230168db
+function satisfiesVersion(v1: string, v2: string): boolean {
+  const isGTECheck = /^\d+?\.\d+?\.\d+?$/.test(v2);
+  return semver.satisfies(v1, isGTECheck ? `>=${v2}` : v2);
+}
+
 function isAcceptable(
   params: AutocompleteParameters,
   entry: {
@@ -310,7 +316,10 @@ function isAcceptable(
       !entry[versionKey] ||
       // TODO: when https://jira.mongodb.org/browse/SPM-2327 is done we can rely on server_version being present
       !connectionInfo?.server_version ||
-      semver.gte(connectionInfo.server_version, entry[versionKey] as string);
+      satisfiesVersion(
+        connectionInfo.server_version,
+        entry[versionKey] as string
+      );
   }
   const isAcceptableEnvironment =
     !entry.env ||

packages/cli-repl/test/repl-helpers.ts

@@ -73,7 +73,7 @@ async function waitEval(bus: MongoshBus) {
 async function waitCompletion(bus: MongoshBus) {
   await Promise.race([
     waitBus(bus, 'mongosh:autocompletion-complete'),
-    new Promise((resolve) => setTimeout(resolve, 5000)?.unref?.()),
+    new Promise((resolve) => setTimeout(resolve, 10_000)?.unref?.()),
   ]);
   await tick();
 }