chore: fix knip --production

Author: gagik

knip.ts

@@ -52,7 +52,7 @@ const config: KnipConfig = {
 
     // Special cases for packages with different entry points
     "packages/cli-repl": {
-      project: ["src/**/*.ts", "bin/**/*.js", "test/**/*.ts"],
+      project: ["src/**/*.ts!", "bin/**/*.js", "test/**/*.ts"],
       ignoreDependencies: [
         // Eagerly loaded startup snapshot dependencies
         "@mongodb-js/saslprep",
@@ -67,17 +67,17 @@ const config: KnipConfig = {
     },
 
     "packages/shell-api": {
-      entry: ["src/api.ts"],
+      entry: ["src/api.ts!", "scripts/*.ts", "test/*.ts"],
     },
 
     "packages/mongosh": {
       project: ["bin/**/*.js"],
     },
 
     "packages/e2e-tests": {
-      entry: ["test/**/*", "test/fixtures/**/*"],
+      entry: ["test/**/*.ts", "test/fixtures/**/*"],
       ignoreDependencies: [
-        // Used indirectly
+        // This is used for version check. TODO: Consider changing that test.
         "@mongosh/cli-repl",
       ],
     },
@@ -109,9 +109,13 @@ const config: KnipConfig = {
       ],
     },
 
+    "packages/errors": {
+      entry: ["src/index.ts!", "scripts/*.ts"],
+    },
+
     "packages/browser-repl": {
-      entry: ["config/*.js"],
-      project: ["src/**/*.{ts,tsx}"],
+      entry: ["src/index.tsx!", "config/*.js"],
+      project: ["src/**/*.{ts,tsx}!"],
       ignoreDependencies: [
         "@wojtekmaj/enzyme-adapter-react-17",
         "enzyme",
@@ -149,7 +153,13 @@ const config: KnipConfig = {
     },
 
     "packages/async-rewriter2": {
-      entry: ["test/fixtures/**/*"],
+      entry: [
+        "src/index.ts!",
+        "bin/*.js!",
+        "test/fixtures/**/*",
+        "scripts/*.js",
+        "benchmark/index.ts",
+      ],
       ignoreFiles: [
         // Used by make-runtime-support.js
         "src/runtime-support.nocov.js",
@@ -185,7 +195,11 @@ const config: KnipConfig = {
 
   // Webpack configuration
   webpack: {
-    config: ["config/webpack.base.config.js", "**/webpack.config.js"],
+    config: [
+      "config/webpack.base.config.js",
+      "**/webpack.config.js",
+      "**/webpack.config.*.js",
+    ],
   },
 
   // ESLint configuration

mongosh.code-workspace

@@ -32,10 +32,6 @@
       "name": "📦 @mongosh/history",
       "path": "packages/history"
     },
-    {
-      "name": "📦 @mongosh/java-shell",
-      "path": "packages/java-shell"
-    },
     {
       "name": "📦 @mongosh/js-multiline-to-singleline",
       "path": "packages/js-multiline-to-singleline"
@@ -64,6 +60,10 @@
       "name": "📦 @mongosh/arg-parser",
       "path": "packages/arg-parser"
     },
+    {
+      "name": "📦 @mongosh/java-shell",
+      "path": "packages/java-shell"
+    },
     {
       "name": "📦 @mongosh/service-provider-core",
       "path": "packages/service-provider-core"

package-lock.json

@@ -14,8 +14,7 @@
     "check-ci": "npm run check --workspaces --if-present",
     "depalign": "depalign",
     "predepcheck": "npm run depalign",
-    "depcheck": "knip",
-    "knip:production": "knip --production --strict",
+    "depcheck": "knip && knip --production",
     "lint": "npm run lint --workspaces --if-present",
     "test": "rimraf .nyc_output && npm run test-coverage --workspaces --if-present && npm run report-coverage",
     "test-ci": "rimraf .nyc_output && npm run test-ci-coverage --workspaces --if-present && npm run post-process-nyc",
@@ -110,7 +109,7 @@
     "find-up": "^5.0.0",
     "glob": "^10.3.12",
     "husky": "^9.0.11",
-    "knip": "^5.69.1",
+    "knip": "^5.71.0",
     "mocha": "^10.2.0",
     "mongodb-runner": "^6.0.0",
     "nyc": "^15.1.0",
@@ -139,14 +138,14 @@
     "packages/build",
     "packages/errors",
     "packages/history",
-    "packages/java-shell",
     "packages/js-multiline-to-singleline",
     "packages/types",
     "packages/i18n",
     "packages/logging",
     "packages/shell-bson",
     "packages/testing",
     "packages/arg-parser",
+    "packages/java-shell",
     "packages/service-provider-core",
     "packages/service-provider-node-driver",
     "packages/shell-api",

package.json

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 'use strict';
-const AsyncWriter = require('../').default;
+const AsyncWriter = require('../lib').default;
 const fs = require('fs');
 const input = fs.readFileSync(process.argv[2], 'utf8');
 const asyncWriter = new AsyncWriter();

packages/async-rewriter2/bin/async-rewrite.js

@@ -21,7 +21,8 @@
     }
   },
   "scripts": {
-    "start": "webpack serve --config ./config/webpack.config.watch.js",
+    "start": "npm run webpack-serve",
+    "webpack-serve": "webpack serve --config ./config/webpack.config.watch.js",
     "clean": "rimraf ./lib",
     "preprepublish": "rimraf ./lib",
     "prepublish": "npm run compile",

packages/async-rewriter2/bin/make-runtime-support.js renamed to packages/async-rewriter2/scripts/make-runtime-support.js

@@ -26,12 +26,6 @@
   "engines": {
     "node": ">=16.15.0"
   },
-  "dependencies": {
-    "@mongosh/cli-repl": "2.5.10",
-    "@mongosh/service-provider-core": "3.7.0",
-    "@mongodb-js/oidc-plugin": "^2.0.5",
-    "strip-ansi": "^6.0.0"
-  },
   "devDependencies": {
     "mongodb-log-writer": "^2.4.3",
     "@mongodb-js/eslint-config-mongosh": "^1.0.0",
@@ -50,6 +44,10 @@
     "mongodb": "^6.19.0",
     "node-fetch": "^3.3.2",
     "prettier": "^2.8.8",
-    "rimraf": "^3.0.2"
+    "rimraf": "^3.0.2",
+    "@mongodb-js/oidc-plugin": "^2.0.5",
+    "strip-ansi": "^6.0.0",
+    "@mongosh/cli-repl": "2.5.10",
+    "@mongosh/service-provider-core": "3.7.0"
   }
 }

packages/browser-repl/package.json

@@ -442,7 +442,7 @@ describe('e2e', function () {
         }
         const currentOp = await shell.executeLine('db.currentOp()');
         const expectedVersion =
-          require('../package.json')['dependencies']['@mongosh/cli-repl'];
+          require('../package.json')['devDependencies']['@mongosh/cli-repl'];
         expect(currentOp).to.include(`appName: 'mongosh ${expectedVersion}'`);
         expect(currentOp).to.include("name: 'nodejs|mongosh'");
         shell.assertNoErrors();

packages/e2e-tests/package.json

@@ -19,7 +19,6 @@
   "dependencies": {
     "@mongodb-js/device-id": "^0.2.1",
     "@mongodb-js/devtools-connect": "^3.9.4",
-    "@mongosh/errors": "2.4.5",
     "@mongosh/types": "^3.14.1",
     "mongodb-log-writer": "^2.4.3",
     "mongodb-redact": "^1.3.0",
@@ -33,7 +32,8 @@
     "depcheck": "^1.4.7",
     "eslint": "^7.25.0",
     "prettier": "^2.8.8",
-    "sinon": "^19.0.4"
+    "sinon": "^19.0.4",
+    "@mongosh/errors": "2.4.5"
   },
   "scripts": {
     "test": "mocha",