fix(tests): update tests to match validator and config changes

Author: gagik

packages/cli-repl/src/cli-repl.spec.ts

@@ -1466,10 +1466,10 @@ describe('CliRepl', function () {
             cliRepl.config.logRetentionGB = testLogRetentionGB;
             await cliRepl.start(await testServer.connectionString(), {});
 
-            expect(cliRepl.getConfig('logRetentionGB')).equals(
+            expect(await cliRepl.getConfig('logRetentionGB')).equals(
               testLogRetentionGB
             );
-            expect(cliRepl.logManager?._options.logRetentionGB).equals(
+            expect(cliRepl.logManager?._options.retentionGB).equals(
               testLogRetentionGB
             );
           });

packages/e2e-tests/test/e2e.spec.ts

@@ -1581,15 +1581,15 @@ describe('e2e', function () {
             await shell.waitForPrompt();
             shell.assertContainsOutput('Ignoring config option "logLocation"');
             shell.assertContainsOutput(
-              'must be a valid absolute path or empty'
+              'must be a valid absolute path or undefined'
             );
 
             expect(
               await shell.executeLine(
                 'config.set("logLocation", "[123123123123]")'
               )
             ).contains(
-              'Cannot set option "logLocation": logLocation must be a valid absolute path or empty'
+              'Cannot set option "logLocation": logLocation must be a valid absolute path or undefined'
             );
           });
 

packages/types/src/index.spec.ts

@@ -32,8 +32,13 @@ describe('config validation', function () {
       'logRetentionDays must be a positive integer'
     );
     expect(await validate('logRetentionGB', 'foo')).to.equal(
-      'logRetentionGB must be a positive integer'
+      'logRetentionGB must be a positive number or undefined'
+    );
+    expect(await validate('logRetentionGB', -1)).to.equal(
+      'logRetentionGB must be a positive number or undefined'
     );
+    expect(await validate('logRetentionGB', undefined)).to.equal(null);
+    expect(await validate('logRetentionGB', 100)).to.equal(null);
     expect(await validate('logRetentionDays', -1)).to.equal(
       'logRetentionGB must be a positive integer'
     );