COMPASS-4116: Fix/Update datalake telemetry reporting by using mongodb-build-info package (#242)

Author: Anemy

lib/instance-detail-helper.js

@@ -4,6 +4,7 @@ const toNS = require('mongodb-ns');
 const security = require('mongodb-security');
 const ReadPreference = require('mongodb').ReadPreference;
 const URL = require('mongodb-url');
+const getMongoDBBuildInfo = require('mongodb-build-info');
 const {
   union,
   map,
@@ -142,18 +143,15 @@ function getGenuineMongoDB(results, done) {
 function getDataLake(results, done) {
   const buildInfo = results.build.raw;
 
-  debug('isDataLake check: buildInfo.queryEngine', buildInfo.queryEngine);
+  debug('isDataLake check: buildInfo.dataLake', buildInfo.dataLake);
+
+  const { isDataLake, dlVersion } = getMongoDBBuildInfo.getDataLake(buildInfo);
 
   const res = {
-    isDataLake: false,
-    version: null
+    isDataLake,
+    version: dlVersion
   };
 
-  if (buildInfo.queryEngine) {
-    res.isDataLake = true;
-    res.version = buildInfo.queryEngine.version;
-  }
-
   done(null, res);
 }
 

package-lock.json

@@ -24,6 +24,7 @@
     "debug": "^4.1.1",
     "lodash": "^4.17.15",
     "mongodb": "^3.5.7",
+    "mongodb-build-info": "^1.1.0",
     "mongodb-collection-sample": "^4.5.1",
     "mongodb-connection-model": "^16.1.4",
     "mongodb-index-model": "^2.6.1",

package.json

@@ -233,12 +233,18 @@ describe('instance-detail-helper-mocked', function() {
   describe('getDataLake', function() {
     it('reports when connected to DataLake', function(done) {
       const results = {
-        build: { raw: { queryEngine: { version: '1.0.0' } } }
+        build: { raw: {
+          dataLake: {
+            version: 'v20200329',
+            gitVersion: '0f318ss78bfad79ede3721e91iasj6f61644f',
+            date: '2020-03-29T15:41:22Z'
+          }
+        } }
       };
       getDataLake(results, function(err, res) {
         assert.equal(err, null);
         assert.equal(res.isDataLake, true);
-        assert.equal(res.version, '1.0.0');
+        assert.equal(res.version, 'v20200329');
         done();
       });
     });