Skip to content

Commit 108cdae

Browse files
committed
🐛 Fix mis-recognizing character '*' as a gitmoji
1 parent 51a32f7 commit 108cdae

File tree

3 files changed

+54
-31
lines changed

3 files changed

+54
-31
lines changed

lib/helper/parse-commits.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
const issueRegex = require('issue-regex')
2-
const emojiRegex = require('emoji-regex/text')
2+
const emojiRegex = require('emoji-regex')
3+
const escapeStringRegex = require('escape-string-regexp')
34
const { emojify } = require('node-emoji')
45
const { gitmojis } = require('gitmojis')
56

@@ -48,7 +49,7 @@ function parseGitmoji ({ subject = '', message = '', body = '' } = {}, issues =
4849

4950
const gitmoji = matched[0]
5051
const semver = gitmojis.find(matchEmoji(gitmoji))?.semver || 'other'
51-
subject = subject.replace(new RegExp('^' + gitmoji), '')
52+
subject = subject.replace(new RegExp('^' + escapeStringRegex(gitmoji)), '')
5253

5354
return { subject, message: subject + '\n\n' + body, gitmoji, semver }
5455
}

package-lock.json

Lines changed: 48 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@
4949
"dependencies": {
5050
"dateformat": "^3.0.3",
5151
"debug": "^4.3.2",
52-
"emoji-regex": "^9.2.2",
52+
"emoji-regex": "^10.3.0",
53+
"escape-string-regexp": "^4.0.0",
5354
"git-url-parse": "^13.0.0",
5455
"gitmojis": "^3.13.4",
5556
"handlebars": "^4.7.6",
@@ -66,4 +67,4 @@
6667
"lib",
6768
"index.js"
6869
]
69-
}
70+
}

0 commit comments

Comments
 (0)