working on singleton services

Author: mjangir

config/development.json

@@ -1,6 +1,6 @@
 {
   "api": {
-    "baseUrl": "http://192.192.7.224:8000/api/v1/"
+    "baseUrl": "http://localhost:8000/api/v1/"
   },
 
   "paths": {

src/app/admin/access/permission/permission.component.ts

@@ -14,7 +14,6 @@ export class PermissionComponent implements OnInit {
   constructor(private router: Router) { }
 
   ngOnInit() {
-    console.log('... Initializing Permissions component');
   }
 
 }

src/app/admin/access/permission/permission.module.ts

@@ -52,8 +52,6 @@ const containers = [
     CommonPipesModule,
     TooltipModule.forRoot(),
     BsDropdownModule.forRoot(),
-    StoreModule.forFeature('accessPermission', reducers),
-    EffectsModule.forFeature(effects),
     SweetAlert2Module,
     AngularMultiSelectModule,
     PermissionRoutingModule

src/app/admin/access/permission/permission.sandbox.ts

@@ -121,6 +121,7 @@ export class AccessPermissionSandbox extends Sandbox {
   ) {
     super();
     this.registerAuthEvents();
+    console.log("calling permission sandbox constructor");
   }
 
   /**

src/app/admin/access/permission/store/reducers/create-permission.reducer.ts

@@ -42,7 +42,9 @@ export function reducer(
         ...state,
         loading: true,
         loaded: false,
-        failed: false
+        failed: false,
+        error: null,
+        permission: null
       }
     }
 

src/app/admin/access/permission/store/reducers/update-permission.reducer.ts

@@ -42,7 +42,9 @@ export function reducer(
         ...state,
         loading: true,
         loaded: false,
-        failed: false
+        failed: false,
+        error: null,
+        permission: null
       }
     }
 

src/app/admin/access/role/containers/create-role/create-role.container.html

@@ -1,7 +1,7 @@
 <div class="card">
-  <form [formGroup]="roleForm" novalidate (ngSubmit)="onSubmit($event, roleForm.value)">
+  <form [formGroup]="form" novalidate (ngSubmit)="onSubmit($event, form.value)">
     <div class="card-header">
-      <i class="fa fa-tag"></i> {{'accessRole.heading.create' | translate}}
+      <i class="fa fa-tag"></i> {{ formTitle }}
     </div>
     <div class="card-body">
       <div class="row">
@@ -65,12 +65,12 @@
       </div>
     </div>
     <div class="card-footer">
-      <button class="btn btn-outline-primary px-3" [disabled]="roleForm.invalid" type="submit">
-        <i [hidden]="accessRoleSandbox.createRoleLoading$ | async" class='fa fa-save'></i>
-        <i [hidden]="!(accessRoleSandbox.createRoleLoading$ | async)" class='fa fa-circle-o-notch fa-spin'></i>
+      <button class="btn btn-outline-primary px-3" [disabled]="form.invalid" type="submit">
+        <i [hidden]="loadingObservable$ | async" class='fa fa-save'></i>
+        <i [hidden]="!(loadingObservable$ | async)" class='fa fa-circle-o-notch fa-spin'></i>
         {{'btn.lbl.submit' | translate}}
       </button>
-        <button type="submit" class="btn btn-outline-danger" routerLink="/admin/access/role/list"><i class="fa fa-arrow-left"></i> {{'btn.lbl.goBack' | translate}}</button>
+        <button type="button" class="btn btn-outline-danger" routerLink="/admin/access/role/list"><i class="fa fa-arrow-left"></i> {{'btn.lbl.goBack' | translate}}</button>
     </div>
   </form>
 </div>

src/app/admin/access/role/containers/create-role/create-role.container.ts

@@ -1,7 +1,5 @@
 import { 
-  Component, 
-  OnDestroy, 
-  OnInit, 
+  Component,
   Injector,
   ChangeDetectionStrategy 
 }                             from '@angular/core';
@@ -14,7 +12,7 @@ import RoleForm               from '../../models/role-form.model';
   styleUrls: ['./create-role.container.scss'],
   changeDetection: ChangeDetectionStrategy.OnPush
 })
-export class CreateRoleContainer extends RoleFormContainer implements OnInit {
+export class CreateRoleContainer extends RoleFormContainer {
 
   /**
    * Creates an instance of UpdateRoleContainer.
@@ -26,16 +24,8 @@ export class CreateRoleContainer extends RoleFormContainer implements OnInit {
     injector: Injector
   ) {
     super(injector);
-  }
-
-  /**
-   * On Init container
-   * 
-   * @memberof CreateRoleContainer
-   */
-  ngOnInit() {
-    this.registerSubscriptions();
-    this.accessPermissionSandbox.getPermissions();
+    this.formTitle          = this.translateService.instant('accessRole.heading.create');
+    this.loadingObservable$ = this.accessRoleSandbox.createRoleLoading$;
   }
 
   /**
@@ -56,15 +46,4 @@ export class CreateRoleContainer extends RoleFormContainer implements OnInit {
 
     this.accessRoleSandbox.createRole(new RoleForm(formData));
   }
-
-  /**
-   * Unsubscribe from all Observables
-   * 
-   * @memberof CreateRoleContainer
-   */
-  public onNgDestroy() {
-    this.routerSubscription.unsubscribe();
-    this.accessRoleSandbox.unregisterEvents();
-    this.accessPermissionSandbox.unregisterEvents();
-  }
 }