Add a setting that sets default=None to all optional fields so they can be missing from response and still parse #385
+159
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be missing from response and still parse
Collaborator
|
Hi @etareduction, Thanks for your pull request! Can you add some unit tests to verify your code? |
Contributor
Author
|
@DamianCzajkowski Sorry i was too busy to come through with that, but my friend here came to help and added a few tests. Does it look good? |
DamianCzajkowski
force-pushed
the
main
branch
from
e74ba77 to
e8458ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #309