fix sub-variables are not correctly recovered from sub-fields (#325)

* fix sub-variables are not correctly recovered from sub-fields

* Fixing tests

* fixing formatting

---------

Co-authored-by: Florian Nouviale <your_donotreply_email_id>

Author: flonou

ariadne_codegen/client_generators/dependencies/base_operation.py

@@ -145,12 +145,10 @@ def get_formatted_variables(self) -> Dict[str, Dict[str, Any]]:
 
         # Collect variables from subfields
         for subfield in self._subfields:
-            subfield.get_formatted_variables()
-            formatted_variables.update(subfield.formatted_variables)
+            formatted_variables.update(subfield.get_formatted_variables())
 
         # Collect variables from inline fragments
         for subfields in self._inline_fragments.values():
             for subfield in subfields:
-                subfield.get_formatted_variables()
-                formatted_variables.update(subfield.formatted_variables)
+                formatted_variables.update(subfield.get_formatted_variables())
         return formatted_variables

tests/main/clients/custom_query_builder/expected_client/base_operation.py

@@ -145,12 +145,10 @@ def get_formatted_variables(self) -> Dict[str, Dict[str, Any]]:
 
         # Collect variables from subfields
         for subfield in self._subfields:
-            subfield.get_formatted_variables()
-            formatted_variables.update(subfield.formatted_variables)
+            formatted_variables.update(subfield.get_formatted_variables())
 
         # Collect variables from inline fragments
         for subfields in self._inline_fragments.values():
             for subfield in subfields:
-                subfield.get_formatted_variables()
-                formatted_variables.update(subfield.formatted_variables)
+                formatted_variables.update(subfield.get_formatted_variables())
         return formatted_variables

tests/main/clients/custom_sync_query_builder/expected_client/base_operation.py

@@ -145,12 +145,10 @@ def get_formatted_variables(self) -> Dict[str, Dict[str, Any]]:
 
         # Collect variables from subfields
         for subfield in self._subfields:
-            subfield.get_formatted_variables()
-            formatted_variables.update(subfield.formatted_variables)
+            formatted_variables.update(subfield.get_formatted_variables())
 
         # Collect variables from inline fragments
         for subfields in self._inline_fragments.values():
             for subfield in subfields:
-                subfield.get_formatted_variables()
-                formatted_variables.update(subfield.formatted_variables)
+                formatted_variables.update(subfield.get_formatted_variables())
         return formatted_variables

tests/test_schema.py

@@ -183,7 +183,9 @@ def test_read_graphql_file_with_invalid_file_raises_invalid_graphql_syntax_excep
 ):
     with pytest.raises(InvalidGraphqlSyntax) as exc:
         read_graphql_file(invalid_syntax_schema_file)
-    assert str(invalid_syntax_schema_file) in str(exc)
+    # Use the actual exception value's message to avoid backslash escaping
+    # that can appear in the ExceptionInfo string on Windows.
+    assert str(invalid_syntax_schema_file) in str(exc.value)
 
 
 def test_walk_graphql_files_returns_graphql_files_from_directory(schemas_directory):