Merge pull request #51 from mirko-pagliai/develop

Develop

Author: mirko-pagliai

CHANGELOG.md

@@ -1,4 +1,10 @@
 # 2.x branch
+## 2.7 branch
+### 2.7.0
+* `BackupTrait::getBinary()` method has been moved to `Driver` abstract class;
+* `BackupTrait::getTarget()`, `BackupTrait::getDriverName()` and
+    `BackupTrait::getValidExtensions()` methods have been removed.
+
 ## 2.6 branch
 ### 2.6.6
 * tests have been optimized and speeded up;

src/BackupTrait.php

@@ -17,7 +17,6 @@
 use Cake\Datasource\ConnectionInterface;
 use Cake\Datasource\ConnectionManager;
 use InvalidArgumentException;
-use RuntimeException;
 use Symfony\Component\Filesystem\Filesystem;
 
 /**
@@ -30,32 +29,20 @@ trait BackupTrait
      * @since 2.4.0
      * @var array
      */
-    private static $validExtensions = ['sql.bz2' => 'bzip2', 'sql.gz' => 'gzip', 'sql' => false];
+    protected static $validExtensions = ['sql.bz2' => 'bzip2', 'sql.gz' => 'gzip', 'sql' => false];
 
     /**
      * Returns an absolute path
      * @param string $path Relative or absolute path
      * @return string
-     * @uses getTarget()
      */
     public function getAbsolutePath($path)
     {
-        return (new Filesystem())->isAbsolutePath($path) ? $path : add_slash_term($this->getTarget()) . $path;
-    }
-
-    /**
-     * Gets a binary path
-     * @param string $name Binary name
-     * @return string
-     * @since 2.0.0
-     * @throws \RuntimeException
-     */
-    public function getBinary($name)
-    {
-        $binary = Configure::read('DatabaseBackup.binaries.' . $name);
-        is_true_or_fail($binary, __d('database_backup', 'Binary for `{0}` could not be found. You have to set its path manually', $name), RuntimeException::class);
+        if (!(new Filesystem())->isAbsolutePath($path)) {
+            return add_slash_term(Configure::read('DatabaseBackup.target')) . $path;
+        }
 
-        return $binary;
+        return $path;
     }
 
     /**
@@ -92,12 +79,11 @@ public function getConnection($name = null)
      * @since 2.0.0
      * @throws \InvalidArgumentException
      * @uses getConnection()
-     * @uses getDriverName()
      */
     public function getDriver(ConnectionInterface $connection = null)
     {
         $connection = $connection ?: $this->getConnection();
-        $className = $this->getDriverName($connection);
+        $className = get_class_short_name($connection->getDriver());
         $driver = App::classname(sprintf('%s.%s', 'DatabaseBackup', $className), 'Driver');
         is_true_or_fail(
             $driver,
@@ -108,41 +94,18 @@ public function getDriver(ConnectionInterface $connection = null)
         return new $driver($connection);
     }
 
-    /**
-     * Gets the driver name, according to the database engine
-     * @param \Cake\Datasource\ConnectionInterface|null $connection A connection object
-     * @return string The driver name
-     * @since 2.6.2
-     * @uses getConnection()
-     */
-    public function getDriverName(ConnectionInterface $connection = null)
-    {
-        $connection = $connection ?: $this->getConnection();
-
-        return get_class_short_name($connection->getDriver());
-    }
-
     /**
      * Returns the extension from a filename
      * @param string $filename Filename
      * @return string|null Extension or `null` if the extension is not found or
      *  if is an invalid extension
-     * @uses getValidExtensions()
+     * @uses $validExtensions
      */
     public function getExtension($filename)
     {
         $extension = get_extension($filename);
 
-        return in_array($extension, $this->getValidExtensions()) ? $extension : null;
-    }
-
-    /**
-     * Returns the target path
-     * @return string
-     */
-    public function getTarget()
-    {
-        return Configure::read('DatabaseBackup.target');
+        return in_array($extension, array_keys(self::$validExtensions)) ? $extension : null;
     }
 
     /**
@@ -155,15 +118,4 @@ public function getValidCompressions()
     {
         return array_filter(self::$validExtensions);
     }
-
-    /**
-     * Returns all valid extensions
-     * @return array
-     * @since 2.4.0
-     * @uses $validExtensions
-     */
-    public function getValidExtensions()
-    {
-        return array_keys(self::$validExtensions);
-    }
 }

src/Console/Command.php

@@ -36,7 +36,7 @@ public function execute(Arguments $args, ConsoleIo $io)
         $config = $this->getConnection()->config();
 
         $io->out(__d('database_backup', 'Connection: {0}', $config['name']));
-        $io->out(__d('database_backup', 'Driver: {0}', $this->getDriverName($this->getConnection())));
+        $io->out(__d('database_backup', 'Driver: {0}', get_class_short_name($this->getConnection()->getDriver())));
         $io->hr();
 
         return null;

src/Driver/Driver.php

@@ -17,6 +17,7 @@
 use Cake\Event\EventDispatcherTrait;
 use Cake\Event\EventListenerInterface;
 use DatabaseBackup\BackupTrait;
+use RuntimeException;
 
 /**
  * Represents a driver containing all methods to export/import database backups
@@ -120,6 +121,7 @@ public function beforeImport()
      * @param string $filename Filename where you want to export the database
      * @return string
      * @uses _exportExecutable()
+     * @uses getBinary()
      */
     protected function _exportExecutableWithCompression($filename)
     {
@@ -143,6 +145,7 @@ protected function _exportExecutableWithCompression($filename)
      * @param string $filename Filename from which you want to import the database
      * @return string
      * @uses _importExecutable()
+     * @uses getBinary()
      */
     protected function _importExecutableWithCompression($filename)
     {
@@ -189,6 +192,20 @@ final public function export($filename)
         return file_exists($filename);
     }
 
+    /**
+     * Gets a binary path
+     * @param string $name Binary name
+     * @return string
+     * @throws \RuntimeException
+     */
+    public function getBinary($name)
+    {
+        $binary = Configure::read('DatabaseBackup.binaries.' . $name);
+        is_true_or_fail($binary, sprintf('Binary for `%s` could not be found. You have to set its path manually', $name), RuntimeException::class);
+
+        return $binary;
+    }
+
     /**
      * Gets a config value or the whole configuration
      * @param string|null $key Config key or `null` to get all config values

src/Driver/Mysql.php

@@ -30,6 +30,7 @@ class Mysql extends Driver
     /**
      * Gets the executable command to export the database
      * @return string
+     * @uses getBinary()
      * @uses getConfig()
      * @uses $auth
      */
@@ -46,6 +47,7 @@ protected function _exportExecutable()
     /**
      * Gets the executable command to import the database
      * @return string
+     * @uses getBinary()
      * @uses getConfig()
      * @uses $auth
      */

src/Driver/Postgres.php

@@ -46,6 +46,7 @@ protected function getDbnameAsString()
     /**
      * Gets the executable command to export the database
      * @return string
+     * @uses getBinary()
      * @uses getDbnameAsString()
      */
     protected function _exportExecutable()
@@ -56,6 +57,7 @@ protected function _exportExecutable()
     /**
      * Gets the executable command to import the database
      * @return string
+     * @uses getBinary()
      * @uses getDbnameAsString()
      */
     protected function _importExecutable()

src/Driver/Sqlite.php

@@ -23,6 +23,7 @@ class Sqlite extends Driver
     /**
      * Gets the executable command to export the database
      * @return string
+     * @uses getBinary()
      * @uses getConfig()
      */
     protected function _exportExecutable()
@@ -33,6 +34,7 @@ protected function _exportExecutable()
     /**
      * Gets the executable command to import the database
      * @return string
+     * @uses getBinary()
      * @uses getConfig()
      */
     protected function _importExecutable()

src/TestSuite/DriverTestCase.php

@@ -121,9 +121,10 @@ public function testExport()
      */
     public function testExportAndImport()
     {
-        foreach ($this->getValidExtensions() as $extension) {
+        foreach (self::$validExtensions as $extension) {
             $this->loadFixtures();
-            $backup = $this->getAbsolutePath(sprintf('example.%s', $extension));
+            $backup = uniqid('example_');
+            $backup = $this->getAbsolutePath($extension ? $backup . '.' . $extension : $backup);
 
             //Initial records. 3 articles and 6 comments
             $initial = $this->getAllRecords();
@@ -192,7 +193,7 @@ public function testExportExecutableWithCompression()
             $expected = sprintf(
                 '%s | %s > %s%s',
                 $basicExecutable,
-                $this->getBinary($compression),
+                $this->Driver->getBinary($compression),
                 escapeshellarg($filename),
                 REDIRECT_TO_DEV_NULL
             );
@@ -239,7 +240,7 @@ public function testImportExecutableWithCompression()
             $result = $this->invokeMethod($this->Driver, '_importExecutableWithCompression', [$filename]);
             $expected = sprintf(
                 '%s -dc %s | %s%s',
-                $this->getBinary($compression),
+                $this->Driver->getBinary($compression),
                 escapeshellarg($filename),
                 $basicExecutable,
                 REDIRECT_TO_DEV_NULL

src/Utility/BackupManager.php

@@ -68,7 +68,7 @@ public function deleteAll()
      */
     public function index()
     {
-        $finder = (new Finder())->files()->name('/\.sql(\.(gz|bz2))?$/')->in($this->getTarget());
+        $finder = (new Finder())->files()->name('/\.sql(\.(gz|bz2))?$/')->in(Configure::read('DatabaseBackup.target'));
 
         return collection($finder)->map(function (SplFileInfo $file) {
             return new Entity([

tests/TestCase/BackupTraitTest.php

@@ -21,7 +21,6 @@
 use DatabaseBackup\Driver\Mysql;
 use DatabaseBackup\TestSuite\TestCase;
 use InvalidArgumentException;
-use RuntimeException;
 
 /**
  * BackupTraitTest class
@@ -56,20 +55,6 @@ public function testGetAbsolutePath()
         $this->assertEquals($expected, $this->getAbsolutePath(Configure::read('DatabaseBackup.target') . DS . 'file.txt'));
     }
 
-    /**
-     * Test for `getBinary()` method
-     * @test
-     */
-    public function testGetBinary()
-    {
-        $this->assertEquals(which('mysql'), $this->getBinary('mysql'));
-
-        //With a binary not available
-        $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('Binary for `noExisting` could not be found. You have to set its path manually');
-        $this->getBinary('noExisting');
-    }
-
     /**
      * Test for `getCompression()` method
      * @test
@@ -131,17 +116,6 @@ public function testGetDriver()
         $this->getDriver($connection);
     }
 
-    /**
-     * Test for `getDriverName()` method
-     * @test
-     */
-    public function testGetDriverName()
-    {
-        foreach ([ConnectionManager::get('test'), null] as $driver) {
-            $this->assertEquals('Mysql', $this->getDriverName($driver));
-        }
-    }
-
     /**
      * Test for `getExtension()` method
      * @test
@@ -171,13 +145,4 @@ public function testGetValidCompressions()
     {
         $this->assertNotEmpty($this->getValidCompressions());
     }
-
-    /**
-     * Test for `getValidExtensions()` method
-     * @test
-     */
-    public function testGetValidExtensions()
-    {
-        $this->assertNotEmpty($this->getValidExtensions());
-    }
 }