added BackupTrait::getDriverName() method

Author: mirko-pagliai

CHANGELOG.md

@@ -1,6 +1,7 @@
 # 2.x branch
 ## 2.6 branch
 ### 2.6.2
+* added `BackupTrait::getDriverName()` method;
 * `BackupExport::compression()` takes a compression type name as string or
     `null` to disable compression;
 * `BackupExport::send()` takes a recipient's email address as string or `null`

src/BackupTrait.php

@@ -80,18 +80,19 @@ public function getConnection($name = null)
     }
 
     /**
-     * Gets the driver containing all methods to export/import database backups
-     *  according to the database engine
+     * Gets the driver instance containing all methods to export/import database
+     *  backups, according to the database engine
      * @param \Cake\Datasource\ConnectionInterface|null $connection A connection object
-     * @return object A driver instance
+     * @return object The driver instance
      * @since 2.0.0
      * @throws \InvalidArgumentException
      * @uses getConnection()
+     * @uses getDriverName()
      */
     public function getDriver(ConnectionInterface $connection = null)
     {
         $connection = $connection ?: $this->getConnection();
-        $className = get_class_short_name($connection->getDriver());
+        $className = $this->getDriverName($connection);
         $driver = App::classname(sprintf('%s.%s', 'DatabaseBackup', $className), 'Driver');
         is_true_or_fail(
             $driver,
@@ -102,6 +103,20 @@ public function getDriver(ConnectionInterface $connection = null)
         return new $driver($connection);
     }
 
+    /**
+     * Gets the driver name, according to the database engine
+     * @param \Cake\Datasource\ConnectionInterface|null $connection A connection object
+     * @return string The driver name
+     * @since 2.6.2
+     * @uses getConnection()
+     */
+    public function getDriverName(ConnectionInterface $connection = null)
+    {
+        $connection = $connection ?: $this->getConnection();
+
+        return get_class_short_name(get_class($connection->getDriver()));
+    }
+
     /**
      * Returns the extension from a filename
      * @param string $filename Filename

src/Console/Command.php

@@ -29,15 +29,14 @@ class Command extends BaseCommand
      * Implement this method with your command's logic
      * @param \Cake\Console\Arguments $args The command arguments
      * @param \Cake\Console\ConsoleIo $io The console io
-     * @return null|int The exit code or null for success
+     * @return int|null The exit code or null for success
      */
     public function execute(Arguments $args, ConsoleIo $io)
     {
         $config = $this->getConnection()->config();
-        $driver = $this->getDriver($this->getConnection());
 
         $io->out(__d('database_backup', 'Connection: {0}', $config['name']));
-        $io->out(__d('database_backup', 'Driver: {0}', get_class_short_name($driver)));
+        $io->out(__d('database_backup', 'Driver: {0}', $this->getDriverName($this->getConnection())));
         $io->hr();
 
         return null;

tests/TestCase/BackupTraitTest.php

@@ -131,6 +131,17 @@ public function testGetDriver()
         $this->getDriver($connection);
     }
 
+    /**
+     * Test for `getDriverName()` method
+     * @test
+     */
+    public function testGetDriverName()
+    {
+        foreach ([ConnectionManager::get('test'), null] as $driver) {
+            $this->assertEquals('Mysql', $this->getDriverName($driver));
+        }
+    }
+
     /**
      * Test for `getExtension()` method
      * @test