BackupTrait::getValidExtensions() method has been removed

Author: mirko-pagliai

CHANGELOG.md

@@ -1,7 +1,8 @@
 # 2.x branch
 ## 2.7 branch
 ### 2.7.0
-* `BackupTrait::getTarget()` and `BackupTrait::getDriverName()` have been removed.
+* `BackupTrait::getTarget()`, `BackupTrait::getDriverName()` and
+    `BackupTrait::getValidExtensions()` methods have been removed.
 
 ## 2.6 branch
 ### 2.6.6

src/BackupTrait.php

@@ -30,7 +30,7 @@ trait BackupTrait
      * @since 2.4.0
      * @var array
      */
-    private static $validExtensions = ['sql.bz2' => 'bzip2', 'sql.gz' => 'gzip', 'sql' => false];
+    protected static $validExtensions = ['sql.bz2' => 'bzip2', 'sql.gz' => 'gzip', 'sql' => false];
 
     /**
      * Returns an absolute path
@@ -115,13 +115,13 @@ public function getDriver(ConnectionInterface $connection = null)
      * @param string $filename Filename
      * @return string|null Extension or `null` if the extension is not found or
      *  if is an invalid extension
-     * @uses getValidExtensions()
+     * @uses $validExtensions
      */
     public function getExtension($filename)
     {
         $extension = get_extension($filename);
 
-        return in_array($extension, $this->getValidExtensions()) ? $extension : null;
+        return in_array($extension, array_keys(self::$validExtensions)) ? $extension : null;
     }
 
     /**
@@ -134,15 +134,4 @@ public function getValidCompressions()
     {
         return array_filter(self::$validExtensions);
     }
-
-    /**
-     * Returns all valid extensions
-     * @return array
-     * @since 2.4.0
-     * @uses $validExtensions
-     */
-    public function getValidExtensions()
-    {
-        return array_keys(self::$validExtensions);
-    }
 }

src/TestSuite/DriverTestCase.php

@@ -148,7 +148,7 @@ public function testExport()
      */
     public function testExportAndImport()
     {
-        foreach ($this->getValidExtensions() as $extension) {
+        foreach (self::$validExtensions as $extension) {
             $this->loadFixtures();
             $backup = $this->getAbsolutePath(sprintf('example.%s', $extension));
 

tests/TestCase/BackupTraitTest.php

@@ -160,13 +160,4 @@ public function testGetValidCompressions()
     {
         $this->assertNotEmpty($this->getValidCompressions());
     }
-
-    /**
-     * Test for `getValidExtensions()` method
-     * @test
-     */
-    public function testGetValidExtensions()
-    {
-        $this->assertNotEmpty($this->getValidExtensions());
-    }
 }