♻️ minor cleanup

Author: ianardee

bin/mindee.rb

@@ -50,7 +50,6 @@
 
 options = {
   api_key: '',
-  raise_on_error: true,
   print_full: false,
 }
 
@@ -95,9 +94,6 @@ def custom_subcommand(options)
   opt.separator('')
   opt.separator("subcommands: #{DOCUMENTS.keys.join(', ')}")
   opt.separator('')
-  opt.on('-E', '--no-raise-errors', "raise errors behavior") do |v|
-    options[:raise_on_error] = false
-  end
   opt.on('-f', '--full', "Print the full data, including pages") do |v|
     options[:print_full] = true
   end
@@ -114,9 +110,7 @@ def custom_subcommand(options)
   exit(1)
 end
 
-mindee_client = Mindee::Client.new(
-  api_key: options[:api_key], raise_on_error: options[:raise_on_error]
-)
+mindee_client = Mindee::Client.new(api_key: options[:api_key])
 
 if command == 'custom'
   if ARGV.length != 2

docs/ruby-getting-started.md

@@ -92,13 +92,20 @@ The following environment variable will set the global API key:
 ```shell
 MINDEE_API_KEY=my-api-key
 ```
-
+ 
 Then in your code:
 ```ruby
 # Init a new client without an API key
 mindee_client = Mindee::Client.new
 ```
 
+### Setting the Request Timeout
+The request timeout can be set using an environment variable:
+```shell
+MINDEE_REQUEST_TIMEOUT=200
+```
+
+
 ## Loading a Document File
 Before being able to send a document to the API, it must first be loaded.
 

lib/mindee/client.rb

@@ -102,9 +102,8 @@ def find_doc_config(document_class, endpoint_name, account_name)
   # Mindee API Client.
   # See: https://developers.mindee.com/docs/
   class Client
-    # @param raise_on_error [Boolean]
-    def initialize(api_key: '', raise_on_error: true)
-      @raise_on_error = raise_on_error
+    # @param api_key [String]
+    def initialize(api_key: '')
       @doc_configs = {}
       @api_key = api_key
       init_default_endpoints

lib/mindee/http/endpoint.rb

@@ -27,7 +27,7 @@ def initialize(owner, url_name, version, api_key: '')
         @owner = owner
         @url_name = url_name
         @version = version
-        @request_timeout = ENV.fetch(REQUEST_TIMEOUT_ENV_NAME, TIMEOUT_DEFAULT)
+        @request_timeout = ENV.fetch(REQUEST_TIMEOUT_ENV_NAME, TIMEOUT_DEFAULT).to_i
         @api_key = api_key.nil? || api_key.empty? ? ENV.fetch(API_KEY_ENV_NAME, API_KEY_DEFAULT) : api_key
         @url_root = "#{BASE_URL_DEFAULT}/products/#{@owner}/#{@url_name}/v#{@version}"
       end