fix: generate_filename

Author: milantarami

.phpunit.result.cache

@@ -1 +1 @@
-C:37:"PHPUnit\Runner\DefaultTestResultCache":1262:{a:2:{s:7:"defects";a:5:{s:44:"LaravelHelpersTest::generate_filename_helper";i:4;s:50:"LaravelHelpersTest::current_datetime_string_helper";i:4;s:42:"LaravelHelpersTest::array_map_assoc_helper";i:4;s:53:"LaravelHelpersTest::create_dir_in_storage_path_helper";i:4;s:44:"LaravelHelpersTest::begin_transaction_helper";i:4;}s:5:"times";a:8:{s:44:"LaravelHelpersTest::generate_filename_helper";d:3.177000000000000046185277824406512081623077392578125;s:50:"LaravelHelpersTest::current_datetime_string_helper";d:0.01000000000000000020816681711721685132943093776702880859375;s:42:"LaravelHelpersTest::file_build_path_helper";d:0.00600000000000000012490009027033011079765856266021728515625;s:42:"LaravelHelpersTest::array_map_assoc_helper";d:0.007000000000000000145716771982051795930601656436920166015625;s:53:"LaravelHelpersTest::create_dir_in_storage_path_helper";d:0.25700000000000000621724893790087662637233734130859375;s:44:"LaravelHelpersTest::begin_transaction_helper";d:0.188000000000000000444089209850062616169452667236328125;s:45:"LaravelHelpersTest::commit_transaction_helper";d:0.00899999999999999931998839741709161899052560329437255859375;s:47:"LaravelHelpersTest::rollback_transaction_helper";d:0.00899999999999999931998839741709161899052560329437255859375;}}}
+C:37:"PHPUnit\Runner\DefaultTestResultCache":1382:{a:2:{s:7:"defects";a:5:{s:44:"LaravelHelpersTest::generate_filename_helper";i:4;s:50:"LaravelHelpersTest::current_datetime_string_helper";i:4;s:42:"LaravelHelpersTest::array_map_assoc_helper";i:4;s:53:"LaravelHelpersTest::create_dir_in_storage_path_helper";i:4;s:44:"LaravelHelpersTest::begin_transaction_helper";i:4;}s:5:"times";a:9:{s:44:"LaravelHelpersTest::generate_filename_helper";d:0.008000000000000000166533453693773481063544750213623046875;s:50:"LaravelHelpersTest::current_datetime_string_helper";d:0.008000000000000000166533453693773481063544750213623046875;s:42:"LaravelHelpersTest::file_build_path_helper";d:0.008000000000000000166533453693773481063544750213623046875;s:42:"LaravelHelpersTest::array_map_assoc_helper";d:0.007000000000000000145716771982051795930601656436920166015625;s:53:"LaravelHelpersTest::create_dir_in_storage_path_helper";d:0.01600000000000000033306690738754696212708950042724609375;s:44:"LaravelHelpersTest::begin_transaction_helper";d:0.0179999999999999986399767948341832379810512065887451171875;s:45:"LaravelHelpersTest::commit_transaction_helper";d:0.008000000000000000166533453693773481063544750213623046875;s:47:"LaravelHelpersTest::rollback_transaction_helper";d:0.008000000000000000166533453693773481063544750213623046875;s:46:"GenerateFilenameTest::generate_filename_helper";d:0.10899999999999999966693309261245303787291049957275390625;}}}

src/Helpers/vanilla-php-helpers.php

@@ -38,7 +38,7 @@ function current_datetime_string($timezone = null)
      */
     function generate_filename($originalFilename)
     {
-        $filename = urlencode(current_datetime_string()) . '_' . $originalFilename;
+        $filename = date('Y-m-d His') . gettimeofday()['usec'] . '_' . $originalFilename;
         return $filename;
     }
 }

tests/GenerateFilenameTest.php

@@ -0,0 +1,14 @@
+<?php
+
+use Orchestra\Testbench\TestCase;
+
+class GenerateFilenameTest extends TestCase
+{
+
+    /** @test */
+    public function generate_filename_helper()
+    {
+        echo generate_filename('file name.jpg');
+        $this->assertTrue(true);
+    }
+}