Skip to content

Some Complex types are getting a Microsoft.graph.entity base type during processing which is incorrect #830

@baywet

Description

@baywet

cloudPcForensicStorageAccount
cloudPcPolicyApplyActionResult
cloudPcPolicyScheduledApplyActionDetail
cloudPcSubscription
customQuestionAnswer
deviceLocalCredential
teamsLicensingDetails
aiInteractionAttachment
aiInteractionContext
aiInteractionLink
aiInteractionMention

All have a base type of entity, which semantically is wrong.

This is most likely caused by this line
https://github.com/OneDrive/apidoctor/blame/f63e4085fc133a04e86c640dced1c36b1e8df46e/ApiDoctor.Console/Program.cs#L1692

causing the types that are actually getting generated to inherit from entity https://github.com/microsoftgraph/msgraph-sdk-dotnet/blob/7fc9ce7d9db18155e0e2ef3cd61e34d4d47e7f30/src/Microsoft.Graph/Generated/Models/TeamsLicensingDetails.cs#L12

Side effects being:

  • extraneous id property
  • inaccurate inheritance structure

Touching api doctor is a huge risk, and a huge cost, and the negative effects do not mandate this at this time. Logging for historical purposes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions