fix: refine export assignment diagnostics to match strada #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Sep 6, 2025
...data/baselines/reference/submodule/conformance/jsDeclarationsFunctionPrototypeStatic.js.diff
Outdated
Show resolved
Hide resolved
Member
|
@sandersn @weswigham Is this the thing we were discussing about relaxing this for even TS code and not erroring at all? I can't remember where we left that. |
Member
|
We're at the "just do it like strada" stage because trying to improve it just moved where the jank in our code is - better the jank we know. |
weswigham
approved these changes
Sep 10, 2025
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
Definitely an improvement. I'm sure we'll have to keep adjusting the JS declaration emit for export assignments, though, since they're still only partially supported.
testdata/baselines/reference/submodule/conformance/jsDeclarationsFunctionPrototypeStatic.js
Outdated
Show resolved
Hide resolved
jakebailey
reviewed
Sep 10, 2025
testdata/baselines/reference/submodule/conformance/jsDeclarationsTypeAliases.js.diff
Outdated
Show resolved
Hide resolved
jakebailey
reviewed
Sep 10, 2025
testdata/baselines/reference/submodule/conformance/jsDeclarationsTypedefAndImportTypes.js.diff
Outdated
Show resolved
Hide resolved
jakebailey
reviewed
Sep 10, 2025
...nes/reference/submodule/conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff
Outdated
Show resolved
Hide resolved
a-tarasyuk
changed the title
Member
|
Why the deletion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.