User/jmaxson/loading fixes #328
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaxson-ms
requested review from
anramanath,
helenkzhang,
mslukebo and
trgibeau
as code owners
mslukebo
reviewed
Sep 26, 2023
...osoft.Performance.SDK.Runtime/Extensibility/DataExtensions/Tables/TableExtensionReference.cs
Show resolved
Hide resolved
mslukebo
reviewed
Sep 26, 2023
helenkzhang
reviewed
Sep 26, 2023
src/Microsoft.Performance.SDK.Runtime/SourceDataCookerReferenceFactory.cs
Outdated
Show resolved
Hide resolved
helenkzhang
previously approved these changes
Sep 26, 2023
mslukebo
previously approved these changes
Sep 26, 2023
helenkzhang
previously approved these changes
Sep 26, 2023
jmaxson-ms
dismissed stale reviews from helenkzhang and mslukebo
via
c1fcad2
jmaxson-ms
force-pushed
the
user/jmaxson/loadingFixes
branch
from
c8b4973 to
c1fcad2
Compare
…pe is more often applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterating over assemblies and looking for extension types, do not attempt to recreate types that have already been loaded. This can happen if an assembly exists in multiple directories.
The runtime was creating an ILogger which wrote to the console. This was a bug as, in some cases, the caller couldn't override this behavior. The default behavior (runtime) now is to not log if a logger is not specified (Logger.Null). Some methods overrides have been added to allow the caller to specify a logger to use.