Skip to content

Commit 080348e

Browse files
committed
Use AZURE_OPENAI_MODEL_NAME and clean capture defaults
1 parent 1844e89 commit 080348e

File tree

4 files changed

+13
-14
lines changed

4 files changed

+13
-14
lines changed

lab/5-Observability/1-OpenAIAgents/weekend_planner.ipynb

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
"- `AZURE_OPENAI_API_KEY`\n",
2828
"- `AZURE_OPENAI_ENDPOINT`\n",
2929
"- `AZURE_OPENAI_API_VERSION`\n",
30+
"- `AZURE_OPENAI_MODEL_NAME`\n",
3031
"- `AZURE_AI_FOUNDRY_NAME`\n",
3132
"- `AZURE_AOAI_ACCOUNT`\n",
3233
"- `AZURE_SUBSCRIPTION_ID`\n",
@@ -86,7 +87,7 @@
8687
"LOGGER = logging.getLogger(\"weekend_planner\")\n",
8788
"LOGGER.setLevel(logging.INFO)\n",
8889
"\n",
89-
"MODEL_NAME = os.environ.get(\"AZURE_AI_FOUNDRY_NAME\") or \"gpt-4o-mini\"\n",
90+
"MODEL_NAME = os.environ.get(\"AZURE_OPENAI_MODEL_NAME\") or \"gpt-4o-mini\"\n",
9091
"SERVICE_VERSION = \"1.0.0\"\n"
9192
]
9293
},
@@ -118,15 +119,10 @@
118119
" \"\"\"Enable GenAI capture toggles required by the instrumentation layer.\"\"\"\n",
119120
"\n",
120121
" capture_defaults = {\n",
121-
" \"OTEL_INSTRUMENTATION_OPENAI_AGENTS_CAPTURE_CONTENT\": \"true\",\n",
122-
" \"OTEL_INSTRUMENTATION_OPENAI_AGENTS_CAPTURE_METRICS\": \"true\",\n",
123122
" \"OTEL_GENAI_CAPTURE_MESSAGES\": \"true\",\n",
124123
" \"OTEL_GENAI_CAPTURE_SYSTEM_INSTRUCTIONS\": \"true\",\n",
125124
" \"OTEL_GENAI_CAPTURE_TOOL_DEFINITIONS\": \"true\",\n",
126125
" \"OTEL_GENAI_EMIT_OPERATION_DETAILS\": \"true\",\n",
127-
" \"OTEL_GENAI_AGENT_NAME\": \"Weekend Planner Agent\",\n",
128-
" \"OTEL_GENAI_AGENT_DESCRIPTION\": \"Assistant that plans weekend activities using weather and events data\",\n",
129-
" \"OTEL_GENAI_AGENT_ID\": \"weekend-planner\",\n",
130126
" \"OTEL_GENAI_PROVIDER_NAME\": provider,\n",
131127
" }\n",
132128
" for key, value in capture_defaults.items():\n",
@@ -144,6 +140,7 @@
144140
"\n",
145141
" endpoint = os.environ[\"AZURE_OPENAI_ENDPOINT\"].rstrip(\"/\")\n",
146142
" api_version = os.environ.get(\"AZURE_OPENAI_API_VERSION\", \"2024-05-01-preview\")\n",
143+
" model_name = os.environ.get(\"AZURE_OPENAI_MODEL_NAME\") or \"gpt-4o-mini\"\n",
147144
" api_key = os.environ[\"AZURE_OPENAI_API_KEY\"]\n",
148145
"\n",
149146
" def _build_client() -> openai.AsyncAzureOpenAI:\n",
@@ -155,7 +152,7 @@
155152
"\n",
156153
" return _ApiConfig(\n",
157154
" build_client=_build_client,\n",
158-
" model_name=MODEL_NAME,\n",
155+
" model_name=model_name,\n",
159156
" base_url=endpoint,\n",
160157
" provider=\"azure.ai.openai\",\n",
161158
" )\n",

lab/5-Observability/2-LangChain/weekend_planner.ipynb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"- `AZURE_OPENAI_API_KEY`\n",
2525
"- `AZURE_OPENAI_ENDPOINT`\n",
2626
"- `AZURE_OPENAI_API_VERSION`\n",
27+
"- `AZURE_OPENAI_MODEL_NAME`\n",
2728
"- `AZURE_AI_FOUNDRY_NAME`\n",
2829
"- `AZURE_AOAI_ACCOUNT`\n",
2930
"- `AZURE_SUBSCRIPTION_ID`\n",
@@ -72,7 +73,7 @@
7273
"LOGGER = logging.getLogger(\"weekend_planner\")\n",
7374
"LOGGER.setLevel(logging.INFO)\n",
7475
"\n",
75-
"MODEL_DEPLOYMENT = os.environ.get(\"AZURE_AI_FOUNDRY_NAME\") or \"gpt-4o-mini\"\n"
76+
"MODEL_NAME = os.environ.get(\"AZURE_OPENAI_MODEL_NAME\") or \"gpt-4o-mini\"\n"
7677
]
7778
},
7879
{
@@ -99,9 +100,9 @@
99100
" azure_endpoint=os.environ[\"AZURE_OPENAI_ENDPOINT\"],\n",
100101
" api_key=os.environ[\"AZURE_OPENAI_API_KEY\"],\n",
101102
" api_version=os.environ.get(\"AZURE_OPENAI_API_VERSION\", \"2024-05-01-preview\"),\n",
102-
" azure_deployment=MODEL_DEPLOYMENT,\n",
103+
" azure_deployment=MODEL_NAME,\n",
103104
")\n",
104-
"print(\"Model configured with deployment:\", MODEL_DEPLOYMENT)\n"
105+
"print(\"Model configured with model:\", MODEL_NAME)\n"
105106
]
106107
},
107108
{

lab/5-Observability/3-LangGraph/music_router.ipynb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"- `AZURE_OPENAI_API_KEY`\n",
2525
"- `AZURE_OPENAI_ENDPOINT`\n",
2626
"- `AZURE_OPENAI_API_VERSION`\n",
27+
"- `AZURE_OPENAI_MODEL_NAME`\n",
2728
"- `AZURE_AI_FOUNDRY_NAME`\n",
2829
"- `AZURE_AOAI_ACCOUNT`\n",
2930
"- `AZURE_SUBSCRIPTION_ID`\n",
@@ -66,7 +67,7 @@
6667
"\n",
6768
"load_dotenv(override=True)\n",
6869
"\n",
69-
"MODEL_DEPLOYMENT = os.environ.get(\"AZURE_AI_FOUNDRY_NAME\") or \"gpt-4o-mini\"\n"
70+
"MODEL_NAME = os.environ.get(\"AZURE_OPENAI_MODEL_NAME\") or \"gpt-4o-mini\"\n"
7071
]
7172
},
7273
{
@@ -93,9 +94,9 @@
9394
" azure_endpoint=os.environ[\"AZURE_OPENAI_ENDPOINT\"],\n",
9495
" api_key=os.environ[\"AZURE_OPENAI_API_KEY\"],\n",
9596
" api_version=os.environ.get(\"AZURE_OPENAI_API_VERSION\", \"2024-05-01-preview\"),\n",
96-
" azure_deployment=MODEL_DEPLOYMENT,\n",
97+
" azure_deployment=MODEL_NAME,\n",
9798
")\n",
98-
"print(\"Model ready with deployment:\", MODEL_DEPLOYMENT)\n"
99+
"print(\"Model ready with model:\", MODEL_NAME)\n"
99100
]
100101
},
101102
{

lab/5-Observability/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Both packages automatically apply the GenAI semantic conventions and expose togg
3232

3333
## Running the Samples
3434

35-
1. Export the following environment variables before running any notebook (set unused values to an empty string): `AZURE_OPENAI_API_KEY`, `AZURE_OPENAI_ENDPOINT`, `AZURE_OPENAI_API_VERSION`, `AZURE_AI_FOUNDRY_NAME`, `AZURE_AOAI_ACCOUNT`, `AZURE_SUBSCRIPTION_ID`, `AZURE_RESOURCE_GROUP`, `AZURE_AISEARCH_ENDPOINT`, `AZURE_AISEARCH_INDEX`, `AZURE_AISEARCH_RESOURCE_GROUP`, and `APPLICATION_INSIGHTS_CONNECTION_STRING`.
35+
1. Export the following environment variables before running any notebook (set unused values to an empty string): `AZURE_OPENAI_API_KEY`, `AZURE_OPENAI_ENDPOINT`, `AZURE_OPENAI_API_VERSION`, `AZURE_OPENAI_MODEL_NAME`, `AZURE_AI_FOUNDRY_NAME`, `AZURE_AOAI_ACCOUNT`, `AZURE_SUBSCRIPTION_ID`, `AZURE_RESOURCE_GROUP`, `AZURE_AISEARCH_ENDPOINT`, `AZURE_AISEARCH_INDEX`, `AZURE_AISEARCH_RESOURCE_GROUP`, and `APPLICATION_INSIGHTS_CONNECTION_STRING`.
3636
1. Export an `APPLICATION_INSIGHTS_CONNECTION_STRING` if you want spans to flow into Azure Monitor; otherwise the scripts fall back to console exporters so you can inspect payloads locally.
3737
1. Open any notebook (for example, `lab/5-Observability/1-OpenAIAgents/weekend_planner.ipynb`) and run the cells in order. Observe the emitted spans and confirm that the GenAI attributes align with the semantic conventions.
3838

0 commit comments

Comments
 (0)