Improved coverage for coveralls

Author: rbitting

tests/lib/rules/utils/ruleFactory.test.ts

@@ -89,7 +89,7 @@ describe("hasAccessibleLabel (unit)", () => {
         allowDescribedBy: true,
         messageId: "errorMsg",
         description: "anything",
-        allowLabeledChild: false
+        allowLabeledChild: true
     };
 
     test("returns false when no heuristics pass", () => {
@@ -150,11 +150,46 @@ describe("hasAccessibleLabel (unit)", () => {
         expect(hasAccessibleLabel(node, {}, cfg)).toBe(true);
     });
 
-    test("true when allowDescribedByBy and hasAssociatedLabelViaAriaDescribedBy(...) === true", () => {
+    test("true when allowDescribedBy and hasAssociatedLabelViaAriaDescribedBy(...) === true", () => {
         (hasAssociatedLabelViaAriaDescribedby as jest.Mock).mockReturnValue(true);
         const node = makeOpeningElement("RadioGroup");
         expect(hasAccessibleLabel(node, {}, cfg)).toBe(true);
     });
+
+    test("true when allowLabeledChild and hasLabeledChild(...) === true", () => {
+        (hasLabeledChild as jest.Mock).mockReturnValue(true);
+        const node = makeOpeningElement("RadioGroup");
+        expect(hasAccessibleLabel(node, {}, cfg)).toBe(true);
+    });
+
+    describe("With all configs disabled", () => {
+        const disabledCfg: LabeledControlConfig = {
+            component: "RadioGroup",
+            allowFieldParent: false,
+            allowHtmlFor: false,
+            allowLabelledBy: false,
+            allowWrappingLabel: false,
+            allowTooltipParent: false,
+            allowDescribedBy: false,
+            messageId: "noUnlabeledRadioGroup",
+            description: "Accessibility: RadioGroup must have a programmatic and visual label.",
+            allowLabeledChild: false
+        };
+        test("returns false when all helpers return true but config is disabled", () => {
+            (hasDefinedProp as jest.Mock).mockReset().mockReturnValue(true);
+            (hasNonEmptyProp as jest.Mock).mockReset().mockReturnValue(true);
+            (hasAssociatedLabelViaAriaLabelledBy as jest.Mock).mockReset().mockReturnValue(true);
+            (hasAssociatedLabelViaAriaDescribedby as jest.Mock).mockReset().mockReturnValue(true);
+            (isInsideLabelTag as jest.Mock).mockReset().mockReturnValue(true);
+            (hasAssociatedLabelViaHtmlFor as jest.Mock).mockReset().mockReturnValue(true);
+            (hasFieldParent as jest.Mock).mockReset().mockReturnValue(true);
+            (hasLabeledChild as jest.Mock).mockReset().mockReturnValue(true);
+            (hasToolTipParent as jest.Mock).mockReset().mockReturnValue(true);
+            const node = makeOpeningElement("RadioGroup");
+            const result = hasAccessibleLabel(node, {}, disabledCfg);
+            expect(result).toBe(false);
+        });
+    });
 });
 
 /* -------------------------------------------------------------------------- */
@@ -176,7 +211,7 @@ describe("makeLabeledControlRule (RuleTester integration)", () => {
         allowDescribedBy: true,
         messageId: "noUnlabeledRadioGroup",
         description: "Accessibility: RadioGroup must have a programmatic and visual label.",
-        allowLabeledChild: false
+        allowLabeledChild: true
     };
 
     // 1) No heuristics -> report