-
Notifications
You must be signed in to change notification settings - Fork 37
Description
The activity iterator does not handle events in the same order that I would expect it to.
In the following scenario:
With activities within the Until loop as below:
The behaviour is not as would be expected. It appears that the addition of the failure condition to refresh the token causes the final activities (within the next If conditional) to not be evaluated. In addition, on the second iteration of the loop, the activities are evaluated out of sequence.
pl_package_import.json
test_package_import.py
Attached above are the files, to run successfully these would need to be added to a directory pipeline for pl_package_import.json and tests for test_package_import.py.
In this particular test, it is expected that it goes into the loop, then it processes the next activity in sequence. As it is incomplete, the condition should assess that it goes onto the next iteration of the Until loop. However, it raises exception NoRemainingPipelineActivitiesMeetDependencyConditionsError.
Removing lines 113 to 278 of the pipeline file fixes this, see the file below. This suggests that there is a bug where activities have a success and failure branch in terms of evaluating the next activities.
pl_package_import.json
I also note that the activities in the next iterations are evaluated out of order. For the second pl_package_import.json (i.e. the one that passes the test) where it compares if it goes into the if statement and runs a pipeline in the event of the conditional being false, the next activity should be a Wait activity, being the first one in the loop, but in reality it is the Web Activity, the second activity in the loop.