fix analyzer warnings: IDE0024, IDE0039, IDE0066, IDE0010, IDE0074, IDE0075, SA1500, SA1515, CA1827, IDE0044 (#317)

* fix IDE0024: Use expression body for operators

* fix IDE0039: Use local function

* fix IDE0066: Use 'switch' expression

* fix IDE0010: Populate switch

* fix IDE0074: Use compound assignment

* fix  IDE0075: Conditional expression can be simplified

* fix SA1500: Braces for multi-line statements should not share line

* fix SA1515: Single-line comment should be preceded by blank line

* fix CA1827: Do not use Count() or LongCount() when Any() can be used

* fix  IDE0044: Add readonly modifier

Author: RushabhBhansali

.editorconfig

@@ -738,9 +738,6 @@ dotnet_diagnostic.CA1036.severity = suggestion
 # CA1001: Types that own disposable fields should be disposable
 dotnet_diagnostic.CA1001.severity = suggestion
 
-# CA1827: Do not use Count() or LongCount() when Any() can be used
-dotnet_diagnostic.CA1827.severity = suggestion
-
 # CA1064: Exceptions should be public
 dotnet_diagnostic.CA1064.severity = suggestion
 
@@ -756,21 +753,12 @@ dotnet_diagnostic.CA1834.severity = suggestion
 # SA1202: Elements should be ordered by access
 dotnet_diagnostic.SA1202.severity = suggestion
 
-# SA1500: Braces for multi-line statements should not share line
-dotnet_diagnostic.SA1500.severity = suggestion
-
-# SA1515: Single-line comment should be preceded by blank line
-dotnet_diagnostic.SA1515.severity = suggestion
-
 # IDE0022: Use expression body for methods
 dotnet_diagnostic.IDE0022.severity = suggestion
 
 # IDE0090: Simplify new expression
 dotnet_diagnostic.IDE0090.severity = suggestion
 
-# IDE0044: Add readonly modifier
-dotnet_diagnostic.IDE0044.severity = suggestion
-
 # IDE0065: 'using' directive placement
 dotnet_diagnostic.IDE0065.severity = suggestion
 
@@ -829,27 +817,9 @@ dotnet_diagnostic.IDE0027.severity = suggestion
 # IDE0120: Simplify LINQ expression
 dotnet_diagnostic.IDE0120.severity = suggestion
 
-# IDE0075: Conditional expression can be simplified
-dotnet_diagnostic.IDE0075.severity = suggestion
-
 # IDE0037: Member name can be simplified
 dotnet_diagnostic.IDE0037.severity = suggestion
 
-# IDE0066: Use 'switch' expression
-dotnet_diagnostic.IDE0066.severity = suggestion
-
-# IDE0074: Use compound assignment
-dotnet_diagnostic.IDE0074.severity = suggestion
-
-# IDE0024: Use expression body for operators
-dotnet_diagnostic.IDE0024.severity = suggestion
-
-# IDE0010: Populate switch
-dotnet_diagnostic.IDE0010.severity = suggestion
-
-# IDE0039: Use local function
-dotnet_diagnostic.IDE0039.severity = suggestion
-
 # CA1724: Type names should not match namespaces
 dotnet_diagnostic.CA1724.severity = suggestion
 

src/Microsoft.ComponentDetection.Common/CommandLineInvocationService.cs

@@ -15,7 +15,7 @@ namespace Microsoft.ComponentDetection.Common
     [Export(typeof(ICommandLineInvocationService))]
     public class CommandLineInvocationService : ICommandLineInvocationService
     {
-        private IDictionary<string, string> commandLocatableCache = new ConcurrentDictionary<string, string>();
+        private readonly IDictionary<string, string> commandLocatableCache = new ConcurrentDictionary<string, string>();
 
         public async Task<bool> CanCommandBeLocated(string command, IEnumerable<string> additionalCandidateCommands = null, DirectoryInfo workingDirectory = null, params string[] parameters)
         {

src/Microsoft.ComponentDetection.Common/DependencyGraph/ComponentRecorder.cs

@@ -98,7 +98,7 @@ public class SingleFileComponentRecorder : ISingleFileComponentRecorder
 
             private readonly ComponentRecorder recorder;
 
-            private object registerUsageLock = new object();
+            private readonly object registerUsageLock = new object();
 
             public SingleFileComponentRecorder(string location, ComponentRecorder recorder, bool enableManualTrackingOfExplicitReferences, ILogger log)
             {

src/Microsoft.ComponentDetection.Common/DependencyGraph/DependencyGraph.cs

@@ -13,9 +13,9 @@ namespace Microsoft.ComponentDetection.Common.DependencyGraph
 {
     internal class DependencyGraph : IDependencyGraph
     {
-        private ConcurrentDictionary<string, ComponentRefNode> componentNodes;
+        private readonly ConcurrentDictionary<string, ComponentRefNode> componentNodes;
 
-        private bool enableManualTrackingOfExplicitReferences;
+        private readonly bool enableManualTrackingOfExplicitReferences;
 
         public DependencyGraph(bool enableManualTrackingOfExplicitReferences)
         {

src/Microsoft.ComponentDetection.Common/FileWritingService.cs

@@ -12,8 +12,8 @@ public class FileWritingService : IFileWritingService
     {
         public const string TimestampFormatString = "yyyyMMddHHmmssfff";
 
-        private object lockObject = new object();
-        private string timestamp = DateTime.Now.ToString(TimestampFormatString);
+        private readonly object lockObject = new object();
+        private readonly string timestamp = DateTime.Now.ToString(TimestampFormatString);
 
         public string BasePath { get; private set; }
 

src/Microsoft.ComponentDetection.Common/PathUtilityService.cs

@@ -31,7 +31,7 @@ public class PathUtilityService : IPathUtilityService
 
         private readonly ConcurrentDictionary<string, string> resolvedPaths = new ConcurrentDictionary<string, string>();
 
-        private object isRunningOnWindowsContainerLock = new object();
+        private readonly object isRunningOnWindowsContainerLock = new object();
         private bool? isRunningOnWindowsContainer = null;
 
         public bool IsRunningOnWindowsContainer

src/Microsoft.ComponentDetection.Common/SafeFileEnumerable.cs

@@ -19,7 +19,7 @@ public class SafeFileEnumerable : IEnumerable<MatchedFile>
 
         private readonly EnumerationOptions enumerationOptions;
 
-        private HashSet<string> enumeratedDirectories;
+        private readonly HashSet<string> enumeratedDirectories;
 
         public SafeFileEnumerable(DirectoryInfo directory, IEnumerable<string> searchPatterns, ILogger logger, IPathUtilityService pathUtilityService, ExcludeDirectoryPredicate directoryExclusionPredicate, bool recursivelyScanDirectories = true, HashSet<string> previouslyEnumeratedDirectories = null)
         {

src/Microsoft.ComponentDetection.Common/TabularStringFormat.cs

@@ -10,11 +10,11 @@ public class TabularStringFormat
         public const char DefaultVerticalLineChar = '|';
         public const char DefaultHorizontalLineChar = '_';
 
-        private IList<Column> columns;
-        private int totalWidth;
-        private char horizontalLineChar;
-        private char verticalLineChar;
-        private string tableTitle;
+        private readonly IList<Column> columns;
+        private readonly int totalWidth;
+        private readonly char horizontalLineChar;
+        private readonly char verticalLineChar;
+        private readonly string tableTitle;
 
         public TabularStringFormat(IList<Column> columns, char horizontalLineChar = DefaultHorizontalLineChar, char verticalLineChar = DefaultVerticalLineChar, string tableTitle = null)
         {

src/Microsoft.ComponentDetection.Common/Telemetry/CommandLineTelemetryService.cs

@@ -13,7 +13,7 @@ namespace Microsoft.ComponentDetection.Common.Telemetry
     [TelemetryService(nameof(CommandLineTelemetryService))]
     internal class CommandLineTelemetryService : ITelemetryService
     {
-        private static ConcurrentQueue<JObject> records = new ConcurrentQueue<JObject>();
+        private static readonly ConcurrentQueue<JObject> Records = new ConcurrentQueue<JObject>();
 
         public const string TelemetryRelativePath = "ScanTelemetry_{timestamp}.json";
 
@@ -27,7 +27,7 @@ internal class CommandLineTelemetryService : ITelemetryService
 
         public void Flush()
         {
-            this.FileWritingService.WriteFile(TelemetryRelativePath, JsonConvert.SerializeObject(records));
+            this.FileWritingService.WriteFile(TelemetryRelativePath, JsonConvert.SerializeObject(Records));
         }
 
         public void PostRecord(IDetectionTelemetryRecord record)
@@ -38,7 +38,7 @@ public void PostRecord(IDetectionTelemetryRecord record)
                 jsonRecord.Add("Timestamp", DateTime.UtcNow);
                 jsonRecord.Add("CorrelationId", TelemetryConstants.CorrelationId);
 
-                records.Enqueue(jsonRecord);
+                Records.Enqueue(jsonRecord);
 
                 if (this.telemetryMode == TelemetryMode.Debug)
                 {

src/Microsoft.ComponentDetection.Common/Telemetry/Records/BaseDetectionTelemetryRecord.cs

@@ -6,7 +6,7 @@ namespace Microsoft.ComponentDetection.Common.Telemetry.Records
 {
     public abstract class BaseDetectionTelemetryRecord : IDetectionTelemetryRecord
     {
-        private Stopwatch stopwatch = new Stopwatch();
+        private readonly Stopwatch stopwatch = new Stopwatch();
 
         private bool disposedValue = false;