Fix the setting of variables for QueryAzureDevOpsExtensionVersion@3 (#341)

* Restore old `outputVariable` input, But this time with warning.
* Adding old Extension.Version behavior back in with best level of compatibility.
* Removing default value from outputVariable, This prevents the YAML helper from automatically adding it in.
* Remove the outputVariable declaration from the task.json
* Always set both local and output variables for `Extension.Version`

Author: jessehouwing

BuildTasks/ExtensionVersion/v3/ExtensionVersion.ts

@@ -9,7 +9,17 @@ function setVersion(version: string) {
     if (tl.getBoolInput("setBuildNumber", false)) {
         tl.command("build.updatebuildnumber", null, version);
     }
+    
+    const outputVariable = tl.getInput("outputVariable", false);
+    if (outputVariable) {
+        const setOutputFlag = tl.getBoolInput("setOutputFlag", false) || false;
+        tl.warning("Using of deprecated 'outputVariable' parameter. Remove this parameter and add 'name: {{Stepname}}' to this step and reference '{{StepName}}.Extension.Version' in a future step instead.");
+        tl.setVariable(outputVariable, version, false, setOutputFlag);
+    }
 
+    console.log("Setting local variable 'Extension.Version'.");
+    tl.setVariable("Extension.Version", version, false, false);
+    console.log("Setting output variable '{{StepName}}.Extension.Version'.");
     tl.setVariable("Extension.Version", version, false, true);
 }
 

BuildTasks/ExtensionVersion/v3/task.json

@@ -122,6 +122,24 @@
       "helpMarkDown": "Updates the Build Number with the new version number.",
       "groupName": "version"
     },
+    {
+      "name": "outputVariable",
+      "type": "string",
+      "label": "Output Variable (deprecated)",
+      "defaultValue": "",
+      "required": false,
+      "helpMarkDown": "The variable name to assign the version to. Specify only the name, e.g.: `ExtensionVersion`, not `$(ExtensionVersion)`.",
+      "groupName": "backcompat"
+    },
+    {
+      "name": "setOutputFlag",
+      "type": "boolean",
+      "label": "Set Output flag on Output Variable (deprecated)",
+      "defaultValue": false,
+      "required": false,
+      "helpMarkDown": "When this is set to true the task will set the Output flag on the provided outputVariable, allowing you to reference the variable across stages and jobs. See: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/set-variables-scripts?view=azure-devops&tabs=bash#set-an-output-variable-for-use-in-future-jobs.",
+      "groupName": "backcompat"
+    },
     {
       "name": "extensionVersionOverride",
       "type": "string",
@@ -150,12 +168,6 @@
         "groupName": "advanced"
     }
   ],
-  "outputVariables": [
-    {
-        "name": "Extension.Version",
-        "description": "Is set with the calculated version number."
-    }
-  ],
   "execution": {
     "Node": {
       "target": "ExtensionVersion/v3/ExtensionVersion.js",

BuildTasks/ExtensionVersion/v4/ExtensionVersion.ts

@@ -10,6 +10,9 @@ function setVersion(version: string) {
         tl.command("build.updatebuildnumber", null, version);
     }
 
+    console.log("Setting local variable 'Extension.Version'.");
+    tl.setVariable("Extension.Version", version, false, false);
+    console.log("Setting output variable '{{StepName}}.Extension.Version'.");
     tl.setVariable("Extension.Version", version, false, true);
 }
 

BuildTasks/ExtensionVersion/v4/task.json

@@ -150,12 +150,6 @@
         "groupName": "advanced"
     }
   ],
-  "outputVariables": [
-    {
-        "name": "Extension.Version",
-        "description": "Is set with the calculated version number."
-    }
-  ],
   "execution": {
     "Node16": {
       "target": "ExtensionVersion/v4/ExtensionVersion.js",