From 56659348406cc0c82ad38b46c30c1e18fde73c13 Mon Sep 17 00:00:00 2001 From: Gary Hsu Date: Wed, 29 Oct 2025 15:39:05 -0700 Subject: [PATCH 1/2] Turn off tests for non-WIndows for now --- .github/workflows/ci.yml | 60 ++++++++++++---------------------------- 1 file changed, 17 insertions(+), 43 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a77c22f..124c39f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,7 +1,10 @@ name: CI on: - workflow_dispatch: + push: + branches: [master] + pull_request: + branches: [master] jobs: windows: @@ -40,16 +43,16 @@ jobs: - name: Configure CMake run: | - cmake -B Build -G Xcode + cmake -B Build -G Xcode -DARCANA_TESTS=OFF - name: Build run: | cmake --build Build --config ${{ matrix.config }} - - name: Test - working-directory: Build - run: | - ctest -C ${{ matrix.config }} --output-on-failure --verbose + # - name: Test + # working-directory: Build + # run: | + # ctest -C ${{ matrix.config }} --output-on-failure --verbose ios: name: iOS @@ -68,43 +71,13 @@ jobs: -DCMAKE_SYSTEM_NAME=iOS \ -DCMAKE_OSX_DEPLOYMENT_TARGET=12.0 \ -DCMAKE_XCODE_ATTRIBUTE_ONLY_ACTIVE_ARCH=NO \ - -DCMAKE_IOS_INSTALL_COMBINED=YES + -DCMAKE_IOS_INSTALL_COMBINED=YES \ + -DARCANA_TESTS=OFF - name: Build for ${{ matrix.platform }} run: | cmake --build Build --config ${{ matrix.config }} -- -sdk ${{ matrix.platform }} - android: - name: Android - runs-on: ubuntu-latest - strategy: - matrix: - config: [Debug, Release] - abi: [armeabi-v7a, arm64-v8a, x86, x86_64] - - steps: - - uses: actions/checkout@v4 - - - name: Setup Android NDK - uses: nttld/setup-ndk@v1 - with: - ndk-version: r25c - add-to-path: false - - - name: Configure CMake for Android - run: | - cmake -B Build \ - -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_ROOT/build/cmake/android.toolchain.cmake \ - -DANDROID_ABI=${{ matrix.abi }} \ - -DANDROID_PLATFORM=android-21 \ - -DCMAKE_BUILD_TYPE=${{ matrix.config }} - env: - ANDROID_NDK_ROOT: ${{ steps.setup-ndk.outputs.ndk-path }} - - - name: Build - run: | - cmake --build Build --config ${{ matrix.config }} - linux: name: Linux runs-on: ubuntu-latest @@ -133,13 +106,14 @@ jobs: cmake -B Build \ -DCMAKE_BUILD_TYPE=${{ matrix.config }} \ -DCMAKE_C_COMPILER=${{ matrix.cc }} \ - -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} + -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} \ + -DARCANA_TESTS=OFF - name: Build run: | cmake --build Build --config ${{ matrix.config }} - - name: Test - working-directory: Build - run: | - ctest -C ${{ matrix.config }} --output-on-failure --verbose + # - name: Test + # working-directory: Build + # run: | + # ctest -C ${{ matrix.config }} --output-on-failure --verbose From 771bd6641d281d7b2a1627e42d16fd00b8c5e71c Mon Sep 17 00:00:00 2001 From: Gary Hsu Date: Wed, 29 Oct 2025 15:43:34 -0700 Subject: [PATCH 2/2] Don't build for header only configurations --- .github/workflows/ci.yml | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 124c39f..b957698 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,10 +45,11 @@ jobs: run: | cmake -B Build -G Xcode -DARCANA_TESTS=OFF - - name: Build - run: | - cmake --build Build --config ${{ matrix.config }} - + # Commented out until tests are re-enabled + # - name: Build + # run: | + # cmake --build Build --config ${{ matrix.config }} + # # - name: Test # working-directory: Build # run: | @@ -74,10 +75,6 @@ jobs: -DCMAKE_IOS_INSTALL_COMBINED=YES \ -DARCANA_TESTS=OFF - - name: Build for ${{ matrix.platform }} - run: | - cmake --build Build --config ${{ matrix.config }} -- -sdk ${{ matrix.platform }} - linux: name: Linux runs-on: ubuntu-latest @@ -109,10 +106,11 @@ jobs: -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} \ -DARCANA_TESTS=OFF - - name: Build - run: | - cmake --build Build --config ${{ matrix.config }} - + # Commented out until tests are re-enabled + # - name: Build + # run: | + # cmake --build Build --config ${{ matrix.config }} + # # - name: Test # working-directory: Build # run: |