Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 24, 2025

The release prepare command was missing the compatibility layer generation check that runs in the main release command.

Changes

  • Extracted shared logic - Created runCompatLayerGenerationCheck() helper in releasePrepChecks.ts that runs layerGeneration:gen and checks for git changes
  • Added check to prepare command - Implemented CheckCompatLayerGeneration following existing check patterns and added to allChecks map in prepare.ts
  • Refactored release command - Updated checkCompatLayerGeneration in checkFunctions.ts to use shared helper, reducing duplication

Both commands now run identical compatibility layer generation checks via shared logic.

// Shared helper used by both commands
export async function runCompatLayerGenerationCheck(context: Context): Promise<boolean> {
  await execa("pnpm", ["run", "-r", "layerGeneration:gen"], { cwd: context.root });
  const gitRepo = await context.getGitRepository();
  const afterGenStatus = await gitRepo.gitClient.status();
  const isClean = afterGenStatus.isClean();
  if (!isClean) {
    await gitRepo.gitClient.reset(ResetMode.HARD);
  }
  return isClean;
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • googlechromelabs.github.io
    • Triggering command: /usr/local/bin/node node install.mjs (dns block)
  • https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.87/linux64/chrome-headless-shell-linux64.zip
    • Triggering command: /usr/local/bin/node node install.mjs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

In the build-tools build-cli project, there is a release command that runs a number of checks. There is also a release prepare command that runs some checks. The prepare command is missing some of the checks, so update the prepare command to run the additional checks. As much of the check logic itself should be shared as possible.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 4 commits November 24, 2025 19:21
Co-authored-by: tylerbutler <19589+tylerbutler@users.noreply.github.com>
Co-authored-by: tylerbutler <19589+tylerbutler@users.noreply.github.com>
Co-authored-by: tylerbutler <19589+tylerbutler@users.noreply.github.com>
Co-authored-by: tylerbutler <19589+tylerbutler@users.noreply.github.com>
Copilot AI changed the title [WIP] Update release prepare command to include additional checks Add CheckCompatLayerGeneration to release prepare command Nov 24, 2025
Copilot finished work on behalf of tylerbutler November 24, 2025 19:30
Copilot AI requested a review from tylerbutler November 24, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants