Skip to content

Don’t mangle markdown links (even better, support them) in commit messages #899

@ericbf

Description

@ericbf

Describe the Bug
Right now, markdown links in the format [anchor text](https://some-link.com) get mangled when inside parentheses or brackets in the text (the closing paren `) is included in the automatic link parsing), rendering them unusable.

It would be nice if markdown links were supported so we can link to various things apart from the single "issue linking" template. We may reference documentation or other resources in our commit messages. But at least they should not be mangled.

For example, if you : Does stuff (see [the docs](https://some-lib.com/docs)). should render as:

Image

But at the very least, the link parsing should not include the closing parenthesis.

Image

Steps to Reproduce
Steps to reproduce the behaviour:

  1. Create a commit message that includes a link inside parens or brackets.
  2. See the commit message in the git graph
  3. Notice the link includes the ), but should not. Ideally it would render as a link using the anchor text.

Expected Behaviour
The link would be rendered as the anchor text, linking to the link URL. Other option is to correctly parse the link so it doesn’t get broken at least.

Environment

  • Git Graph Extension Version: [e.g. 1.13.0]
  • Visual Studio Code Version: [e.g. 1.37.1]
  • Operating System: [e.g. Windows 10]

Screenshots (optional)

Image

Additional Context (optional)

We often include links in parentheses (pull request links) or brackets (issue numbers) in the commit messages themselves, or links to other resources. Would be nice if they worked!

⚠ Please make sure you complete all of the required sections of this template. Without this required information, it will be harder to replicate this bug, and cause additional delays in resolving it.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions