Removed deprecated ParametersAcceptorSelector::selectSingle() (#796)

fixes #795

Author: mglaman

src/Rules/Deprecations/SymfonyCmfRoutingInClassMethodSignatureRule.php

@@ -46,7 +46,11 @@ public function processNode(Node $node, Scope $scope): array
         // @phpstan-ignore-next-line
         $cmfLazyRouteCollectionType = new ObjectType(LazyRouteCollection::class);
 
-        $methodSignature = ParametersAcceptorSelector::selectSingle($method->getVariants());
+        $methodSignature = ParametersAcceptorSelector::selectFromArgs(
+            $scope,
+            [],
+            $method->getVariants()
+        );
 
         $errors = [];
         $errorMessage = 'Parameter $%s of method %s() uses deprecated %s and removed in Drupal 10. Use %s instead.';

src/Type/ContainerDynamicReturnTypeExtension.php

@@ -43,7 +43,11 @@ public function getTypeFromMethodCall(
         MethodCall $methodCall,
         Scope $scope
     ): Type {
-        $returnType = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+        $returnType = ParametersAcceptorSelector::selectFromArgs(
+            $scope,
+            $methodCall->getArgs(),
+            $methodReflection->getVariants()
+        )->getReturnType();
         $methodName = $methodReflection->getName();
 
         if ($methodName === 'has') {

src/Type/DrupalClassResolverDynamicReturnTypeExtension.php

@@ -40,7 +40,11 @@ public function getTypeFromMethodCall(
         Scope $scope
     ): Type {
         if (0 === count($methodCall->getArgs())) {
-            return ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+            return ParametersAcceptorSelector::selectFromArgs(
+                $scope,
+                $methodCall->getArgs(),
+                $methodReflection->getVariants()
+            )->getReturnType();
         }
 
         return DrupalClassResolverReturnType::getType($methodReflection, $methodCall, $scope, $this->serviceMap);

src/Type/DrupalClassResolverReturnType.php

@@ -25,7 +25,11 @@ public static function getType(
     ): Type {
         $arg1 = $scope->getType($methodCall->getArgs()[0]->value);
         if (count($arg1->getConstantStrings()) === 0) {
-            return ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+            return ParametersAcceptorSelector::selectFromArgs(
+                $scope,
+                $methodCall->getArgs(),
+                $methodReflection->getVariants()
+            )->getReturnType();
         }
 
         $serviceName = $arg1->getConstantStrings()[0];

src/Type/DrupalServiceDynamicReturnTypeExtension.php

@@ -44,7 +44,11 @@ public function getTypeFromStaticMethodCall(
         StaticCall $methodCall,
         Scope $scope
     ): Type {
-        $returnType = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+        $returnType = ParametersAcceptorSelector::selectFromArgs(
+            $scope,
+            $methodCall->getArgs(),
+            $methodReflection->getVariants()
+        )->getReturnType();
         if (!isset($methodCall->args[0])) {
             return $returnType;
         }

src/Type/DrupalStaticEntityQueryDynamicReturnTypeExtension.php

@@ -45,7 +45,11 @@ public function getTypeFromStaticMethodCall(
         StaticCall $methodCall,
         Scope $scope
     ): Type {
-        $returnType = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+        $returnType = ParametersAcceptorSelector::selectFromArgs(
+            $scope,
+            $methodCall->getArgs(),
+            $methodReflection->getVariants()
+        )->getReturnType();
         if (!$returnType instanceof ObjectType) {
             return $returnType;
         }

src/Type/EntityQuery/AccessCheckTypeSpecifyingExtension.php

@@ -40,7 +40,11 @@ public function specifyTypes(
         Scope $scope,
         TypeSpecifierContext $context
     ): SpecifiedTypes {
-        $returnType = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+        $returnType = ParametersAcceptorSelector::selectFromArgs(
+            $scope,
+            [],
+            $methodReflection->getVariants()
+        )->getReturnType();
         $expr = $node->var;
         if (!$returnType instanceof EntityQueryType) {
             return new SpecifiedTypes([]);

src/Type/EntityQuery/EntityQueryAccessCheckDynamicReturnTypeExtension.php

@@ -32,7 +32,11 @@ public function getTypeFromMethodCall(
         $varType = $scope->getType($methodCall->var);
 
         if (!$varType instanceof EntityQueryType) {
-            return ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+            return ParametersAcceptorSelector::selectFromArgs(
+                $scope,
+                $methodCall->getArgs(),
+                $methodReflection->getVariants()
+            )->getReturnType();
         }
 
         return $varType->withAccessCheck();

src/Type/EntityQuery/EntityQueryDynamicReturnTypeExtension.php

@@ -36,7 +36,11 @@ public function getTypeFromMethodCall(
         MethodCall $methodCall,
         Scope $scope
     ): Type {
-        $defaultReturnType = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+        $defaultReturnType = ParametersAcceptorSelector::selectFromArgs(
+            $scope,
+            $methodCall->getArgs(),
+            $methodReflection->getVariants()
+        )->getReturnType();
         $varType = $scope->getType($methodCall->var);
         $methodName = $methodReflection->getName();
 

src/Type/EntityRepositoryReturnTypeExtension.php

@@ -61,7 +61,11 @@ public function getTypeFromMethodCall(
     ): ?Type {
         $methodName = $methodReflection->getName();
         $methodArgs = $methodCall->getArgs();
-        $returnType = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+        $returnType = ParametersAcceptorSelector::selectFromArgs(
+            $scope,
+            $methodCall->getArgs(),
+            $methodReflection->getVariants()
+        )->getReturnType();
 
         if (count($methodArgs) === 0) {
             return $returnType;