Add rule identifiers

Author: mglaman

src/Rules/Classes/ClassExtendsInternalClassRule.php

@@ -76,6 +76,7 @@ private function buildError(?string $currentClassName, string $extendedClassName
             '%s extends @internal class %s.',
             $currentClassName !== null ? sprintf('Class %s', $currentClassName) : 'Anonymous class',
             $extendedClassName
-        ));
+        ))
+            ->identifier('class.extendsInternalClass');
     }
 }

src/Rules/Classes/PluginManagerInspectionRule.php

@@ -67,6 +67,7 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         if (!$hasAlterInfoSet) {
+            // @todo identifier
             $errors[] = 'Plugin definitions cannot be altered.';
         }
 
@@ -117,6 +118,7 @@ private function inspectYamlPluginManager(Node\Stmt\Class_ $class): array
         $constructor = $reflection->getConstructor();
 
         if ($constructor->getDeclaringClass()->getName() !== $fqn) {
+            // @todo identifier
             $errors[] = sprintf('%s must override __construct if using YAML plugins.', $fqn);
         } else {
             foreach ($class->stmts as $stmt) {
@@ -130,6 +132,7 @@ private function inspectYamlPluginManager(Node\Stmt\Class_ $class): array
                             && ((string)$constructorStmt->class === 'parent')
                             && $constructorStmt->name instanceof Node\Identifier
                             && $constructorStmt->name->name === '__construct') {
+                            // @todo identifier
                             $errors[] = sprintf('YAML plugin managers should not invoke its parent constructor.');
                         }
                     }

src/Rules/Deprecations/AccessDeprecatedConstant.php

@@ -8,6 +8,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
 use function array_merge;
 use function explode;
 use function sprintf;
@@ -124,7 +125,9 @@ public function processNode(Node $node, Scope $scope): array
         $constantName = $this->reflectionProvider->resolveConstantName($node->name, $scope);
         if (isset($deprecatedConstants[$constantName])) {
             return [
-                sprintf('Call to deprecated constant %s: %s', $constantName, $deprecatedConstants[$constantName])
+                RuleErrorBuilder::message(sprintf('Call to deprecated constant %s: %s', $constantName, $deprecatedConstants[$constantName]))
+                ->identifier('constant.deprecated')
+                ->build()
             ];
         }
         return [];

src/Rules/Deprecations/ConditionManagerCreateInstanceContextConfigurationRule.php

@@ -51,6 +51,7 @@ public function processNode(Node $node, Scope $scope): array
                 return [
                     RuleErrorBuilder::message('Passing context values to plugins via configuration is deprecated in drupal:9.1.0 and will be removed before drupal:10.0.0. Instead, call ::setContextValue() on the plugin itself. See https://www.drupal.org/node/3120980')
                         ->line($node->getStartLine())
+                        ->identifier('drupal.deprecated.pluginConfigurationContextKey')
                         ->build()
                 ];
             }

src/Rules/Deprecations/ConfigEntityConfigExportRule.php

@@ -7,6 +7,7 @@
 use PHPStan\PhpDoc\ResolvedPhpDocBlock;
 use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
 use PHPStan\Reflection\ClassReflection;
+use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\ShouldNotHappenException;
 use function preg_match;
 
@@ -32,7 +33,9 @@ protected function doProcessNode(ClassReflection $reflection, Node\Stmt\Class_ $
         }
         if ($hasMatch === 0) {
             return [
-                'Configuration entity must define a `config_export` key. See https://www.drupal.org/node/2481909',
+                RuleErrorBuilder::message('Configuration entity must define a `config_export` key. See https://www.drupal.org/node/2481909')
+                    ->identifier('drupal.deprecated.configEntityConfigExportKey')
+                    ->build(),
             ];
         }
         return [];

src/Rules/Deprecations/DeprecatedHookImplementation.php

@@ -98,7 +98,7 @@ private function buildError(string $function_name, string $hook_name, ?string $d
         return [
             RuleErrorBuilder::message(
                 "Function $function_name implements $hook_name which is deprecated$deprecated_description",
-            )->build()
+            )->identifier('drupal.deprecated.hook')->build()
         ];
     }
 }

src/Rules/Deprecations/GetDeprecatedServiceRule.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
 
 /**
  * @implements Rule<Node\Expr\MethodCall>
@@ -57,7 +58,11 @@ public function processNode(Node $node, Scope $scope): array
 
         $service = $this->serviceMap->getService($serviceName->value);
         if (($service instanceof DrupalServiceDefinition) && $service->isDeprecated()) {
-            return [$service->getDeprecatedDescription()];
+            return [
+                RuleErrorBuilder::message($service->getDeprecatedDescription())
+                    ->identifier('drupal.deprecated.service')
+                    ->build()
+            ];
         }
 
         return [];

src/Rules/Deprecations/PluginAnnotationContextDefinitionsRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ClassReflection;
+use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\ShouldNotHappenException;
 use function preg_match;
 
@@ -30,7 +31,9 @@ protected function doProcessNode(ClassReflection $reflection, Node\Stmt\Class_ $
         }
         if ($hasMatch === 1) {
             return [
-                'Providing context definitions via the "context" key is deprecated in Drupal 8.7.x and will be removed before Drupal 9.0.0. Use the "context_definitions" key instead.',
+                RuleErrorBuilder::message('Providing context definitions via the "context" key is deprecated in Drupal 8.7.x and will be removed before Drupal 9.0.0. Use the "context_definitions" key instead.')
+                    ->identifier('drupal.deprecated.pluginAnnotationContextKey')
+                    ->build(),
             ];
         }
         return [];

src/Rules/Deprecations/StaticServiceDeprecatedServiceRule.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
 
 /**
  * @implements Rule<Node\Expr\StaticCall>
@@ -66,7 +67,11 @@ public function processNode(Node $node, Scope $scope): array
 
         $service = $this->serviceMap->getService($serviceName->value);
         if (($service instanceof DrupalServiceDefinition) && $service->isDeprecated()) {
-            return [$service->getDeprecatedDescription()];
+            return [
+                RuleErrorBuilder::message($service->getDeprecatedDescription())
+                    ->identifier('drupal.deprecated.service')
+                    ->build()
+            ];
         }
 
         return [];

src/Rules/Deprecations/SymfonyCmfRouteObjectInterfaceConstantsRule.php

@@ -57,13 +57,15 @@ public function processNode(Node $node, Scope $scope): array
 
         $coreRouteObjectInterfaceType = new ObjectType(RouteObjectInterface::class);
         if (!$coreRouteObjectInterfaceType->hasConstant($constantName)->yes()) {
+            // @todo identifier
             return [
                 RuleErrorBuilder::message(
                     sprintf('The core dependency symfony-cmf/routing is deprecated and %s::%s is not supported.', $className, $constantName)
                 )->tip('Change record: https://www.drupal.org/node/3151009')->build(),
             ];
         }
 
+        // @todo identifier
         return [
             RuleErrorBuilder::message(
                 sprintf('%s::%s is deprecated and removed in Drupal 10. Use \Drupal\Core\Routing\RouteObjectInterface::%2$s instead.', $className, $constantName)