Font Button Style & Eslint #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
|
Hi Chetan. I was looking at the changes, and I noticed the font styles are being set individually on several components. As you've just added @mui/material, maybe we could take advantage of its ThemeProvider? |
Member
Author
|
Great idea, I’ll move the font settings into the MUI theme instead of applying them individually. |
This was referenced Nov 3, 2025
Closed
Contributor
|
@ChetanFTW resolve merge conflicts |
Signed-off-by: Chetan 👾 <128224987+ChetanFTW@users.noreply.github.com>
Signed-off-by: Chetan 👾 <128224987+ChetanFTW@users.noreply.github.com>
Member
Author
|
hey @saurabhraghuvanshii, i resolve the merge conflict -- could you check for package |
package.json
Outdated
Comment on lines
1
to
5
| { | ||
| "devDependencies": { | ||
| "@jridgewell/resolve-uri": "^3.1.2" | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
why this file??
Contributor
|
many changes will break the site |
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Member
Author
|
PTAL @saurabhraghuvanshii |
| @@ -0,0 +1,2070 @@ | |||
| { | |||
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: Chetan 👾 <128224987+ChetanFTW@users.noreply.github.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Before:
After:
Signed commits