[CI] Update CI workflows #127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
leecalcote
added
area/ci
Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
Revolyssup
reviewed
Dec 1, 2022
| go-version: 1.19 | ||
| check-latest: true | ||
| cache: true | ||
| - name: Create cluster using KinD |
Contributor
There was a problem hiding this comment.
@acald-creator Why does running the unit tests require a kind cluster?
Contributor
Author
There was a problem hiding this comment.
@Revolyssup From the original file at https://github.com/meshery/meshery-app-mesh/blob/master/.github/workflows/ci.yml this is already there. The only difference I did was removed the other checks such as errcheck, vet and gosec because golangci-lint already does this.
This is the same test done through all the adapters repo. Does this section need to be revised or removed?
Contributor
Author
There was a problem hiding this comment.
Also this is reflected in the Makefile as well
## Run Golang tests
test: dep-check
export CURRENTCONTEXT="$(kubectl config current-context)"
echo "current-context:" ${CURRENTCONTEXT}
export KUBECONFIG="${HOME}/.kube/config"
echo "environment-kubeconfig:" ${KUBECONFIG}
GOPROXY=direct GOSUMDB=off GO111MODULE=on go test -v ./...Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
acald-creator
changed the title
Contributor
Author
|
bump |
Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonette Caldwell pullmana8@gmail.com
Description
This PR fixes some of the repetitive workflows.
We should start working toward updating golangci-lint to the latest, and also note that some of the steps in the workflows are already implemented within
golangci-lintsuch aserrcheckandgosec.This current file
.golangci.ymlis copied from the other repos, so this will need to be updated accordingly.Notes for Reviewers
Signed commits