Fix rendering for empty datasets

Jelte Lagendijk · Jelte Lagendijk · commit 413a34bc3d12 · 2016-04-08T11:07:53.000+02:00
diff --git a/src/ChartJS/widgets/BarChart/widget/BarChart.js b/src/ChartJS/widgets/BarChart/widget/BarChart.js
@@ -50,7 +50,8 @@ define([
                     for (k = 0; k < maxpoints; k++) {
                         points.push(0);
                     }
-                    logger.debug(this.id + " - empty dataset");
+                    logger.warn(this.id + " - empty dataset");
+                    continue;
                 }
 
                 set.points = this._sortArrayMx(set.points, this.sortingxvalue);
diff --git a/src/ChartJS/widgets/LineChart/widget/LineChart.js b/src/ChartJS/widgets/LineChart/widget/LineChart.js
@@ -50,7 +50,8 @@ define([
                     for (k = 0; k < maxpoints; k++) {
                         points.push(0);
                     }
-                    logger.debug(this.id + " - empty dataset");
+                    logger.warn(this.id + " - empty dataset");
+                    continue;
                 }
 
                 set.points = this._sortArrayMx(set.points, this.sortingxvalue);
diff --git a/src/ChartJS/widgets/RadarChart/widget/RadarChart.js b/src/ChartJS/widgets/RadarChart/widget/RadarChart.js
@@ -52,7 +52,8 @@ define([
                     for(k=0; k < maxpoints; k++) {
                         points.push(0);
                     }
-                    console.log(this.id + " - empty dataset");
+                    logger.warn(this.id + " - empty dataset");
+                    continue;
                 }
 
                 set.points = this._sortArrayMx(set.points, this.sortingxvalue);
diff --git a/src/ChartJS/widgets/StackedBarChart/widget/StackedBarChart.js b/src/ChartJS/widgets/StackedBarChart/widget/StackedBarChart.js
@@ -51,7 +51,8 @@ define([
                     for(k=0; k < maxpoints; k++) {
                         points.push(0);
                     }
-                    console.log(this.id + " - empty dataset");
+                    logger.warn(this.id + " - empty dataset");
+                    continue;
                 }
 
                 set.points = this._sortArrayMx(set.points, this.sortingxvalue);
diff --git a/test/widgets/ChartJS.mpk b/test/widgets/ChartJS.mpk

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,8 @@ define([`
`50`	`50`	`for (k = 0; k < maxpoints; k++) {`
`51`	`51`	`points.push(0);`
`52`	`52`	`}`
`53`		`- logger.debug(this.id + " - empty dataset");`
	`53`	`+ logger.warn(this.id + " - empty dataset");`
	`54`	`+ continue;`
`54`	`55`	`}`
`55`	`56`
`56`	`57`	`set.points = this._sortArrayMx(set.points, this.sortingxvalue);`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,8 @@ define([`
`52`	`52`	`for(k=0; k < maxpoints; k++) {`
`53`	`53`	`points.push(0);`
`54`	`54`	`}`
`55`		`- console.log(this.id + " - empty dataset");`
	`55`	`+ logger.warn(this.id + " - empty dataset");`
	`56`	`+ continue;`
`56`	`57`	`}`
`57`	`58`
`58`	`59`	`set.points = this._sortArrayMx(set.points, this.sortingxvalue);`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ define([`
`51`	`51`	`for(k=0; k < maxpoints; k++) {`
`52`	`52`	`points.push(0);`
`53`	`53`	`}`
`54`		`- console.log(this.id + " - empty dataset");`
	`54`	`+ logger.warn(this.id + " - empty dataset");`
	`55`	`+ continue;`
`55`	`56`	`}`
`56`	`57`
`57`	`58`	`set.points = this._sortArrayMx(set.points, this.sortingxvalue);`