Upgrade WPCS to latest

Author: mbabker

composer.json

@@ -8,10 +8,10 @@
         "composer-runtime-api": "^2.0"
     },
     "require-dev": {
-        "dealerdirect/phpcodesniffer-composer-installer": "0.7.2",
+        "dealerdirect/phpcodesniffer-composer-installer": "1.0.0",
         "phpcompatibility/phpcompatibility-wp": "2.1.4",
-        "squizlabs/php_codesniffer": "3.7.1",
-        "wp-coding-standards/wpcs": "2.3"
+        "squizlabs/php_codesniffer": "3.7.2",
+        "wp-coding-standards/wpcs": "3.0.1"
     },
     "config": {
         "allow-plugins": {

includes/class-bbpress-allowed-shortcodes-admin.php

@@ -81,7 +81,7 @@ public function register_plugin_options_page(): void {
 		add_options_page(
 			__( 'bbPress Allowed Shortcodes', 'bbpress-allowed-shortcodes' ),
 			__( 'bbPress Allowed Shortcodes', 'bbpress-allowed-shortcodes' ),
-			'administrator',
+			'manage_options',
 			'bbpress-allowed-shortcodes',
 			[ $this, 'show_settings_page' ],
 		);
@@ -112,8 +112,8 @@ public function register_plugin_settings(): void {
 	/**
 	 * Prints the allowed shortcodes list field.
 	 */
-	public function print_bbpress_allowed_shortcodes_list_field( array $args ): void {
-		echo sprintf(
+	public function print_bbpress_allowed_shortcodes_list_field(): void {
+		printf(
 			'<input type="text" id="bbpress_allowed_shortcodes_list" name="bbpress_allowed_shortcodes_list" class="regular-text code" value="%s" />',
 			esc_attr( get_option( 'bbpress_allowed_shortcodes_list', '' ) )
 		);

includes/class-bbpress-allowed-shortcodes-autoloader.php

@@ -64,28 +64,28 @@ public static function unregister(): void {
 	/**
 	 * Auto-load function for plugin classes.
 	 *
-	 * @param string $class Class name.
+	 * @param string $class_name Class name.
 	 */
-	public function autoload( string $class ): void {
-		$class = strtolower( $class );
+	public function autoload( string $class_name ): void {
+		$class_name = strtolower( $class_name );
 
 		// Only attempt to load classes if they look like they come from this plugin
-		if ( strpos( $class, 'bbpress_allowed_shortcodes_' ) !== 0 ) {
+		if ( strpos( $class_name, 'bbpress_allowed_shortcodes_' ) !== 0 ) {
 			return;
 		}
 
-		$file = $this->get_file_name_from_class_name( $class );
+		$file = $this->get_file_name_from_class_name( $class_name );
 
 		$this->include_file_if_readable( $this->include_path . $file );
 	}
 
 	/**
 	 * Take a class name and turn it into a file name.
 	 *
-	 * @param string $class Class name.
+	 * @param string $class_name Class name.
 	 */
-	private function get_file_name_from_class_name( string $class ): string {
-		return 'class-' . str_replace( '_', '-', $class ) . '.php';
+	private function get_file_name_from_class_name( string $class_name ): string {
+		return 'class-' . str_replace( '_', '-', $class_name ) . '.php';
 	}
 
 	/**

phpcs.xml

@@ -11,7 +11,7 @@
 
     <!-- These rules come from the WordPress coding standards -->
     <rule ref="WordPress-Extra">
-        <exclude name="Generic.Arrays.DisallowShortArraySyntax.Found" />
+        <exclude name="Universal.Arrays.DisallowShortArraySyntax.Found" />
         <exclude name="WordPress.PHP.YodaConditions.NotYoda" />
     </rule>