Use lowercase letters for the lifetime elision mismatch suggestion

Author: Noratrieb

compiler/rustc_infer/src/infer/error_reporting/nice_region_error/different_lifetimes.rs

@@ -220,7 +220,7 @@ impl<'a, 'tcx> NiceRegionError<'a, 'tcx> {
                         };
 
                         e.multipart_suggestion(
-                            "Explicitly declare a lifetime and assign it to both",
+                            "explicitly declare a lifetime and assign it to both",
                             vec![
                                 add_lifetime_param,
                                 if let hir::LifetimeName::Underscore = lifetime_sub.name {
@@ -237,7 +237,7 @@ impl<'a, 'tcx> NiceRegionError<'a, 'tcx> {
                             Applicability::MaybeIncorrect,
                         );
                         e.note(
-                            "Each elided lifetime in input position becomes a distinct lifetime.",
+                            "each elided lifetime in input position becomes a distinct lifetime",
                         );
                     }
                 }

src/test/ui/lifetimes/issue-90170-elision-mismatch.stderr

@@ -6,8 +6,8 @@ LL | fn foo(slice_a: &mut [u8], slice_b: &mut [u8]) {
 LL |     core::mem::swap(&mut slice_a, &mut slice_b);
    |                                   ^^^^^^^^^^^^ ...but data from `slice_b` flows into `slice_a` here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo<'a>(slice_a: &'a mut [u8], slice_b: &'a mut [u8]) {
    |       ++++           ++                     ++
@@ -22,8 +22,8 @@ LL | fn foo(slice_a: &mut [u8], slice_b: &mut [u8]) {
 LL |     core::mem::swap(&mut slice_a, &mut slice_b);
    |                                   ^^^^^^^^^^^^ ...but data from `slice_a` flows into `slice_b` here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo<'a>(slice_a: &'a mut [u8], slice_b: &'a mut [u8]) {
    |       ++++           ++                     ++
@@ -36,8 +36,8 @@ LL | fn foo2<U, W, O>(slice_a: &mut [u8], slice_b: &mut [u8], _: U, _: W, _: O)
 LL |     core::mem::swap(&mut slice_a, &mut slice_b);
    |                                   ^^^^^^^^^^^^ ...but data from `slice_b` flows into `slice_a` here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo2<'a, U, W, O>(slice_a: &'a mut [u8], slice_b: &'a mut [u8], _: U, _: W, _: O) {
    |         +++                    ++                     ++
@@ -52,8 +52,8 @@ LL | fn foo2<U, W, O>(slice_a: &mut [u8], slice_b: &mut [u8], _: U, _: W, _: O)
 LL |     core::mem::swap(&mut slice_a, &mut slice_b);
    |                                   ^^^^^^^^^^^^ ...but data from `slice_a` flows into `slice_b` here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo2<'a, U, W, O>(slice_a: &'a mut [u8], slice_b: &'a mut [u8], _: U, _: W, _: O) {
    |         +++                    ++                     ++

src/test/ui/lifetimes/lifetime-errors/ex3-both-anon-regions-2.stderr

@@ -6,8 +6,8 @@ LL | fn foo(&mut (ref mut v, w): &mut (&u8, &u8), x: &u8) {
 LL |     *v = x;
    |          ^ ...but data from `x` flows here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo<'a>(&mut (ref mut v, w): &mut (&'a u8, &u8), x: &'a u8) {
    |       ++++                             ++               ++

src/test/ui/lifetimes/lifetime-errors/ex3-both-anon-regions-3.stderr

@@ -6,8 +6,8 @@ LL | fn foo(z: &mut Vec<(&u8,&u8)>, (x, y): (&u8, &u8)) {
 LL |     z.push((x,y));
    |             ^ ...but data flows into `z` here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo<'a>(z: &mut Vec<(&'a u8,&u8)>, (x, y): (&'a u8, &u8)) {
    |       ++++               ++                     ++
@@ -20,8 +20,8 @@ LL | fn foo(z: &mut Vec<(&u8,&u8)>, (x, y): (&u8, &u8)) {
 LL |     z.push((x,y));
    |               ^ ...but data flows into `z` here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo<'a>(z: &mut Vec<(&u8,&'a u8)>, (x, y): (&u8, &'a u8)) {
    |       ++++                   ++                      ++

src/test/ui/lifetimes/lifetime-errors/ex3-both-anon-regions-using-fn-items.stderr

@@ -6,8 +6,8 @@ LL | fn foo(x:fn(&u8, &u8), y: Vec<&u8>, z: &u8) {
 LL |   y.push(z);
    |          ^ ...but data from `z` flows into `y` here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo<'a>(x:fn(&u8, &u8), y: Vec<&'a u8>, z: &'a u8) {
    |       ++++                         ++          ++

src/test/ui/lifetimes/lifetime-errors/ex3-both-anon-regions-using-trait-objects.stderr

@@ -6,8 +6,8 @@ LL | fn foo(x:Box<dyn Fn(&u8, &u8)> , y: Vec<&u8>, z: &u8) {
 LL |   y.push(z);
    |          ^ ...but data from `z` flows into `y` here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo<'a>(x:Box<dyn Fn(&'a u8, &'a u8)> , y: Vec<&u8>, z: &u8) {
    |       ++++               ++      ++

src/test/ui/lifetimes/lifetime-errors/ex3-both-anon-regions.stderr

@@ -6,8 +6,8 @@ LL | fn foo(x: &mut Vec<&u8>, y: &u8) {
 LL |     x.push(y);
    |            ^ ...but data from `y` flows into `x` here
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo<'a>(x: &mut Vec<&'a u8>, y: &'a u8) {
    |       ++++              ++          ++

src/test/ui/underscore-lifetime/underscore-lifetime-elison-mismatch.stderr

@@ -6,8 +6,8 @@ LL | fn foo(x: &mut Vec<&'_ u8>, y: &'_ u8) { x.push(y); }
    |                                |
    |                                these two types are declared with different lifetimes...
    |
-   = note: Each elided lifetime in input position becomes a distinct lifetime.
-help: Explicitly declare a lifetime and assign it to both
+   = note: each elided lifetime in input position becomes a distinct lifetime
+help: explicitly declare a lifetime and assign it to both
    |
 LL | fn foo<'a>(x: &mut Vec<&'a u8>, y: &'a u8) { x.push(y); }
    |       ++++              ~~          ~~