TC_049_CS Fix connectorId 0 reservation StatusNotification #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understood the original idea of the code to have some kind of "virtual" reservation on connectorId 0, but now the OCTT really wants to get back StatusNotification with
Reservedon one of the connectors (while the second is made Unavailable by the tool).I think also from the UX point of view, it would be strange to arrive at a CS, see the LED green and available but not be able to charge (because of a reservation on connector 0 you cannot see).
Maybe with this "reserve first available connector" we could simplify some logic in the
ReservationServicecode, but didn't want to get into that now...ReserveNow with no StatusNotification back:
Forcing a status notification send: