restart network stack at hostname change if no AP

Author: KipK

src/app_config.cpp

@@ -266,8 +266,11 @@ void config_changed(String name)
   if(name == "time_zone") {
     config_set_timezone(time_zone);
   } else if(name == "hostname") {
-    net.mDNSStop();
-    net.mDNSStart();
+    // restart network if not in ap mode
+    if (!net.isWifiModeApOnly()) {
+      net.end();
+      net.begin();
+    }
   } else if(name == "flags") {
     divert.setMode((config_divert_enabled() && 1 == config_charge_mode()) ? DivertMode::Eco : DivertMode::Normal);
     if(mqtt_connected() != config_mqtt_enabled()) {

src/net_manager.cpp

@@ -74,6 +74,14 @@ void NetManagerTask::begin()
   }
 }
 
+void NetManagerTask::end()
+{
+  if(NULL != _instance)
+  {
+    MicroTask.stopTask(_instance);
+  }
+}
+
 // -------------------------------------------------------------------
 // Start Access Point
 // Access point is used for wifi network selection
@@ -515,7 +523,15 @@ void NetManagerTask::setup()
   // Initially startup the netwrok to kick things off
   manageState();
 
-  mDNSStart();
+  if (MDNS.begin(esp_hostname.c_str()))
+  {
+    MDNS.addService("http", "tcp", 80);
+    MDNS.addService("openevse", "tcp", 80);
+    MDNS.addServiceTxt("openevse", "tcp", "type", buildenv.c_str());
+    MDNS.addServiceTxt("openevse", "tcp", "version", currentfirmware.c_str());
+    MDNS.addServiceTxt("openevse", "tcp", "id", ESPAL.getLongId());
+    
+  }
 }
 
 unsigned long NetManagerTask::handleMessage()
@@ -790,20 +806,4 @@ bool NetManagerTask::isWiredConnected()
 #else
   return false;
 #endif
-}
-
-void NetManagerTask::mDNSStart() {
-  if (MDNS.begin(esp_hostname.c_str()))
-  {
-    MDNS.addService("http", "tcp", 80);
-    MDNS.addService("openevse", "tcp", 80);
-    MDNS.addServiceTxt("openevse", "tcp", "type", buildenv.c_str());
-    MDNS.addServiceTxt("openevse", "tcp", "version", currentfirmware.c_str());
-    MDNS.addServiceTxt("openevse", "tcp", "id", ESPAL.getLongId());
-    
-  }
-}
-
-void NetManagerTask::mDNSStop() {
-  MDNS.end();
-}
+}

src/net_manager.h

@@ -172,7 +172,8 @@ class NetManagerTask : public MicroTasks::Task
     NetManagerTask(LcdTask &lcd, LedManagerTask &led, TimeManager &time);
 
     void begin();
-
+    void end();
+    
     void wifiScan();
 
     void wifiStart();
@@ -183,8 +184,7 @@ class NetManagerTask : public MicroTasks::Task
     void wifiTurnOnAp();
 
     void wifiScanNetworks(WiFiScanCompleteCallback callback);
-    void mDNSStart();
-    void mDNSStop();
+  
     bool isConnected();
     bool isWifiClientConnected();
     bool isWiredConnected();