Skip to content

Conversation

@DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Nov 18, 2025

Summary

Future TODO

  • It's better if they're just instance methods, however they wouldn't work now if slab is Structure

@DanielYang59 DanielYang59 force-pushed the fix-get-slab-regions-outside-cell branch from 744dbcc to f43c6c7 Compare November 18, 2025 09:10
@DanielYang59 DanielYang59 changed the title Make surface.get_slab_regions a method for Slab, mark SlabGenerator.get_unreconstructed_slabs as private method Relocate surface.get_slab_regions/center_slab as static methods for Slab, mark SlabGenerator.get_unreconstructed_slabs as private method Nov 18, 2025
@DanielYang59 DanielYang59 marked this pull request as ready for review November 18, 2025 09:21
@DanielYang59 DanielYang59 deleted the fix-get-slab-regions-outside-cell branch November 23, 2025 22:56
@DanielYang59
Copy link
Contributor Author

guess it's better to refactor to instance method at some point and avoid such intermeditate relocations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant