Relocate surface.get_slab_regions/center_slab as static methods for Slab, mark SlabGenerator.get_unreconstructed_slabs as private method
#4548
+152
−133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
surface.get_slab_regions/center_slabas static methods for Slab, part of Fixsurface.center_slabhandling of Slab regions separated by vacuum #4547, rationale: these methods are quite specific toSlab, make them methods forSlabfor better groupingsurface.get_slab_regions/center_slabas static methods forSlab, markSlabGenerator.get_unreconstructed_slabsas private method #4548Future TODO
slabisStructure