Skip to content

Commit e0ca338

Browse files
committed
perf: improve base service
1 parent 6f7b2e1 commit e0ca338

File tree

12 files changed

+31
-49
lines changed

12 files changed

+31
-49
lines changed

src/app/controller/account/role.controller.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,11 @@ import ConstRole from '~/core/constants/ConstRole'
99
import { type IReqOptions } from '~/core/interface/ReqOptions'
1010
import HttpResponse from '~/core/modules/response/HttpResponse'
1111
import { asyncHandler } from '~/core/utils/asyncHandler'
12-
import Role from '~/database/entities/Role'
1312
import v1Route from '~/routes/v1'
1413

1514
const route = v1Route
1615
const routePath = `/role`
17-
const newRoleService = new RoleService({
18-
entity: 'role',
19-
repository: Role,
20-
})
16+
const newRoleService = new RoleService()
2117

2218
route.get(
2319
`${routePath}`,

src/app/controller/account/session.controller.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,11 @@ import { env } from '~/config/env'
55
import { type IReqOptions } from '~/core/interface/ReqOptions'
66
import HttpResponse from '~/core/modules/response/HttpResponse'
77
import { asyncHandler } from '~/core/utils/asyncHandler'
8-
import Session from '~/database/entities/Session'
98
import v1Route from '~/routes/v1'
109

1110
const route = v1Route
1211
const routePath = `/session`
13-
const newSessionService = new SessionService({
14-
entity: 'session',
15-
repository: Session,
16-
})
12+
const newSessionService = new SessionService()
1713

1814
route.get(
1915
`${routePath}`,

src/app/controller/account/user.controller.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,12 @@ import ConstRole from '~/core/constants/ConstRole'
99
import { type IReqOptions } from '~/core/interface/ReqOptions'
1010
import HttpResponse from '~/core/modules/response/HttpResponse'
1111
import { asyncHandler } from '~/core/utils/asyncHandler'
12-
import User, { type UserLoginAttributes } from '~/database/entities/User'
12+
import { type UserLoginAttributes } from '~/database/entities/User'
1313
import v1Route from '~/routes/v1'
1414

1515
const route = v1Route
1616
const routePath = `/user`
17-
const newUserService = new UserService({
18-
entity: 'user',
19-
repository: User,
20-
})
17+
const newUserService = new UserService()
2118

2219
route.get(
2320
`${routePath}`,

src/app/controller/auth.controller.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import { type DtoUserAgent } from '~/core/interface/dto/UserAgent'
88
import ErrorResponse from '~/core/modules/response/ErrorResponse'
99
import HttpResponse from '~/core/modules/response/HttpResponse'
1010
import { asyncHandler } from '~/core/utils/asyncHandler'
11-
import Session from '~/database/entities/Session'
1211
import { type UserLoginAttributes } from '~/database/entities/User'
1312
import v1Route from '~/routes/v1'
1413
import authorization from '../middleware/authorization'
@@ -18,10 +17,7 @@ import SessionService from '../service/session.service'
1817
const route = v1Route
1918
const routePath = `/auth`
2019
const newAuthService = new AuthService()
21-
const newSessionService = new SessionService({
22-
entity: 'session',
23-
repository: Session,
24-
})
20+
const newSessionService = new SessionService()
2521

2622
route.post(
2723
`${routePath}/sign-up`,

src/app/controller/upload.controller.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,14 @@ import ConstRole from '~/core/constants/ConstRole'
88
import { type IReqOptions } from '~/core/interface/ReqOptions'
99
import HttpResponse from '~/core/modules/response/HttpResponse'
1010
import { asyncHandler } from '~/core/utils/asyncHandler'
11-
import Upload from '~/database/entities/Upload'
1211
import v1Route from '~/routes/v1'
1312
import authorization from '../middleware/authorization'
1413
import { permissionAccess } from '../middleware/permission'
1514
import UploadService from '../service/upload.service'
1615

1716
const route = v1Route
1817
const routePath = `/upload`
19-
const newUploadService = new UploadService({
20-
entity: 'upload',
21-
repository: Upload,
22-
})
18+
const newUploadService = new UploadService()
2319

2420
route.get(
2521
`${routePath}`,

src/app/job/upload.job.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,9 @@ import { green } from 'colorette'
22
import cron from 'node-cron'
33
import { env } from '~/config/env'
44
import { logger } from '~/config/pino'
5-
import Upload from '~/database/entities/Upload'
65
import UploadService from '../service/upload.service'
76

8-
const newUploadService = new UploadService({
9-
entity: 'upload',
10-
repository: Upload,
11-
})
7+
const newUploadService = new UploadService()
128

139
export class UploadJob {
1410
/**

src/app/middleware/authorization.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,9 @@ import { useToken } from 'expresso-hooks'
44
import _ from 'lodash'
55
import { env } from '~/config/env'
66
import { logger } from '~/config/pino'
7-
import Session from '~/database/entities/Session'
87
import SessionService from '../service/session.service'
98

10-
const newSessionService = new SessionService({
11-
entity: 'session',
12-
repository: Session,
13-
})
9+
const newSessionService = new SessionService()
1410

1511
/**
1612
* Authorization

src/app/service/auth.service.ts

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import ConstRole from '~/core/constants/ConstRole'
1010
import { type IReqOptions } from '~/core/interface/ReqOptions'
1111
import ErrorResponse from '~/core/modules/response/ErrorResponse'
1212
import SendMail from '~/core/utils/sendMails'
13-
import Session from '~/database/entities/Session'
1413
import User, {
1514
type LoginAttributes,
1615
type UserAttributes,
@@ -22,16 +21,8 @@ import OpenStreetMapService from './provider/osm.service'
2221
import SessionService from './session.service'
2322
import UserService from './user.service'
2423

25-
const newUserService = new UserService({
26-
entity: 'user',
27-
repository: User,
28-
})
29-
30-
const newSessionService = new SessionService({
31-
entity: 'session',
32-
repository: Session,
33-
})
34-
24+
const newUserService = new UserService()
25+
const newSessionService = new SessionService()
3526
const newOSMService = new OpenStreetMapService()
3627

3728
export default class AuthService {

src/app/service/role.service.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ import roleSchema from '../schema/role.schema'
33
import BaseService from './base.service'
44

55
export default class RoleService extends BaseService {
6+
constructor() {
7+
super({ entity: 'role', repository: Role })
8+
}
9+
610
/**
711
*
812
* @param formData

src/app/service/session.service.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ import BaseService from './base.service'
1919
const relations = [{ model: User }]
2020

2121
export default class SessionService extends BaseService {
22+
constructor() {
23+
super({ entity: 'session', repository: Session })
24+
}
25+
2226
/**
2327
*
2428
* @param req

0 commit comments

Comments
 (0)